From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26417 invoked by alias); 15 Jul 2013 11:20:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26408 invoked by uid 89); 15 Jul 2013 11:20:39 -0000 X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_05,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 15 Jul 2013 11:20:38 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UygpR-0000im-Qx from Ali_Anwar@mentor.com ; Mon, 15 Jul 2013 04:20:29 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 15 Jul 2013 04:20:29 -0700 Received: from [137.202.157.39] (147.34.91.1) by SVR-ORW-FEM-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server (TLS) id 14.2.247.3; Mon, 15 Jul 2013 04:20:28 -0700 Message-ID: <51E3DAD7.3050100@codesourcery.com> Date: Mon, 15 Jul 2013 11:20:00 -0000 From: ali_anwar User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: Joel Brobecker , Pedro Alves , Subject: Re: Updated patch for Bug 13217 - thread apply all detach throws a SEGFAULT References: <5062EA9B.1060505@codesourcery.com> <871uhnwkf3.fsf@fleche.redhat.com> <50C62BBB.6010404@codesourcery.com> <87hantek1p.fsf@fleche.redhat.com> <50C75319.9080903@codesourcery.com> <50C7628F.5080004@redhat.com> <51DD37FA.8010306@codesourcery.com> <87k3kyfgf1.fsf@fleche.redhat.com> <51DEA530.3020306@codesourcery.com> <878v1anoz2.fsf@fleche.redhat.com> In-Reply-To: <878v1anoz2.fsf@fleche.redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00346.txt.bz2 On 07/14/2013 02:12 AM, Tom Tromey wrote: >>>>>> "Ali" == ali anwar writes: > > Ali> Please find attached updated patch. > > Thanks. > > Ali> + struct thread_info **tp_array; > Ali> + struct thread_info *tp; > Ali> + int i, k; > Ali> + i = 0; > > Either there should be a blank line between the declarations and the > assignment here, or the declaration should read "int i = 0, k;". > > This patch is ok with this fixed. > Thanks, committed the patch with the suggested change. -Ali