From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94915-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11621 invoked by alias); 27 Sep 2012 15:32:57 -0000
Received: (qmail 11612 invoked by uid 22791); 27 Sep 2012 15:32:57 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Sep 2012 15:32:51 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8RFWods009544	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 27 Sep 2012 11:32:50 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8RFWmFd002208	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Thu, 27 Sep 2012 11:32:49 -0400
From: Tom Tromey <tromey@redhat.com>
To: ali_anwar <ali_anwar@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: Updated patch for Bug 13217 - thread apply all detach throws a SEGFAULT
References: <5062EA9B.1060505@codesourcery.com>
Date: Thu, 27 Sep 2012 15:32:00 -0000
In-Reply-To: <5062EA9B.1060505@codesourcery.com> (ali anwar's message of "Wed,	26 Sep 2012 16:44:27 +0500")
Message-ID: <871uhnwkf3.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00638.txt.bz2

>>>>> "Ali" == ali anwar <ali_anwar@codesourcery.com> writes:

Ali> +static int
Ali> +thread_valid (struct thread_info *tp)
Ali> +{
Ali> +  struct thread_info  *utp;
Ali> +  for (utp = thread_list; utp; utp = utp->next)
Ali> +     if (tp == utp)
Ali> +       return 1;
Ali> +  return 0;
Ali> +}

Ali> +  for (tp = thread_list; thread_valid(tp); tp = tp->next)

It seems like this introduces quadratic behavior here.
I think it would be better to avoid this.

Ali> +	if (thread_count() == 0)
Ali> +	  break;

Here too.

Tom