From: Tom Tromey <tom@tromey.com>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: modernize get_frame_pc_if_available
Date: Wed, 13 Aug 2025 12:21:11 -0600 [thread overview]
Message-ID: <871ppfnkvc.fsf@tromey.com> (raw)
In-Reply-To: <20250813130355.2236103-1-guinevere@redhat.com> (Guinevere Larsen's message of "Wed, 13 Aug 2025 10:03:55 -0300")
>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:
Guinevere> Now that GDB supports C++17 features, this indirection of a pointer and
Guinevere> returning boolean is unnecessary, since the function can return an
Guinevere> optional, and code that calls it can check if the optional contains a
Guinevere> value.
Nice change, thanks.
Guinevere> - && frame_pc_p
Guinevere> + && frame_pc
I think gdb normally prefers the explicit check of has_value rather than
relying on the conversion to bool.
Tom
next prev parent reply other threads:[~2025-08-13 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 13:03 Guinevere Larsen
2025-08-13 18:21 ` Tom Tromey [this message]
2025-08-13 19:00 ` Guinevere Larsen
2025-08-13 20:21 ` [PATCH v2] " Guinevere Larsen
2025-08-14 16:08 ` Tom Tromey
2025-08-14 16:40 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ppfnkvc.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox