Re: [PATCH v2] gdb: modernize get_frame_pc_if_available

[Tom Tromey <tom@tromey.com>]

>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:

Guinevere> The convenience function get_frame_pc_if_available would take a pointer
Guinevere> to a variable that should be set if available, and would return a
Guinevere> boolean indicating whether that action was successful or not.

Thanks.

Guinevere> -  if (!get_frame_pc_if_available (frame, &pc))
Guinevere> +  if (!(pc = get_frame_pc_if_available (frame)))

This is kind of cheating but in most spots in the patch it is cleaner
than the alternative.  So I'm inclined to let it slide.

Guinevere>    annotate_frame_begin (print_level ? frame_relative_level (frame) : 0,
Guinevere> -			gdbarch, pc);
Guinevere> +			gdbarch, (pc.has_value ()) ? *pc : 0);

I think this can be written: pc.value_or (0).
Ok with that change.

Approved-By: Tom Tromey <tom@tromey.com>

Tom