Re: [PATCH] gdb: modernize get_frame_pc_if_available

[Guinevere Larsen <guinevere@redhat.com>]

On 8/13/25 3:21 PM, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:
> Guinevere> Now that GDB supports C++17 features, this indirection of a pointer and
> Guinevere> returning boolean is unnecessary, since the function can return an
> Guinevere> optional, and code that calls it can check if the optional contains a
> Guinevere> value.
>
> Nice change, thanks.
>
> Guinevere> -      && frame_pc_p
> Guinevere> +      && frame_pc
>
> I think gdb normally prefers the explicit check of has_value rather than
> relying on the conversion to bool.
Oh we do? I thought because the conversion was defined explicitly in the 
library, it would be fine, but I can update it, no problem.
>
> Tom
>

-- 
Cheers,
Guinevere Larsen
She/it