From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4eoQBsHXnGjDowIAWB0awg (envelope-from ) for ; Wed, 13 Aug 2025 14:21:53 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=S1AmNND2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0DC651E04C; Wed, 13 Aug 2025 14:21:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 48A9D1E04C for ; Wed, 13 Aug 2025 14:21:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AE2EF3858C40 for ; Wed, 13 Aug 2025 18:21:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE2EF3858C40 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=S1AmNND2 Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 6B0B93858D20 for ; Wed, 13 Aug 2025 18:21:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B0B93858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6B0B93858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755109276; cv=none; b=UXLUo+0IXmLcYfnIDMtLplBEFQAqqXkixNOs1XuewDBBbZUSjWvxLMKopI9EN2xnPQPRv/0VKA2Yx7zmHhIlNU9v/bQPlHLEgC2ajRe8dg2vVVSp9twcEjknvyed2DZeZB2HWPK/zpqmoO8AMNoWHQNaRQPTA/cxt1py7uV6dUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755109276; c=relaxed/simple; bh=dnO4pq8bDG15N29TkChyA9WpV30NFgQcdEKlkr9CEuA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=SKXc6w6OFzqKYltNkicBr9hZjFw2oZ8RsShztZwgG3dVEG3oMglvNAM8rhlu9Zb0/0xuUF+j075FqmjIZx3wQ0m+yHLaPtzTHm/sZb0egD5brUV+YGvLXJkn3pcBHRubU24CmqXcel2tGpczONyfSTuzUvsxs89yH8VP1dfHZjs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B0B93858D20 Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id mFeBuxx1l5wATmG67uRkUU; Wed, 13 Aug 2025 18:21:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id mG66uSakTgahDmG66ushJZ; Wed, 13 Aug 2025 18:21:14 +0000 X-Authority-Analysis: v=2.4 cv=faKty1QF c=1 sm=1 tr=0 ts=689cd79b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=2OwXVqhp2XgA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=-TgpxQuZUK-bE0X6NxkA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=T7HT6BtMZBCM80hMqmiLKxR0/YQ5LpnhW/KYjLCZ8Cc=; b=S1AmNND2cd/WUYKQ+Ilbw6dRlJ YiKvh/RrPUvAOYTrzdLSlbOTOWiN+DDe5nMCjiPDot2cSaKIQ+rFp2FDuHX8HdqzDAAIZriHqc/7H lXgad2skcttrC1tHzC2Smu+Ng; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:51812 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1umG64-00000002OiL-3xDz; Wed, 13 Aug 2025 12:21:12 -0600 From: Tom Tromey To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: modernize get_frame_pc_if_available In-Reply-To: <20250813130355.2236103-1-guinevere@redhat.com> (Guinevere Larsen's message of "Wed, 13 Aug 2025 10:03:55 -0300") References: <20250813130355.2236103-1-guinevere@redhat.com> X-Attribution: Tom Date: Wed, 13 Aug 2025 12:21:11 -0600 Message-ID: <871ppfnkvc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1umG64-00000002OiL-3xDz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:51812 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHZFuH4fHbpbhlYH+mWcM8qdezwwzdPim2iy8WnFjv3PewVbMzw81avteIxxUkqKPTSuWOU50NHJ658KzqYewVtFEaLP/noBfqm/uwoUcDosid0xzRse dQlcJhJvoFqHcA7/3ybZEK0v7SiT6BQwk/IWRjgVNTfXBef+PEpIHLPZwyIb+bC0wnXxqnszES4P6oKmy2XITJS2IFs90E7QETk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Guinevere" == Guinevere Larsen writes: Guinevere> Now that GDB supports C++17 features, this indirection of a pointer and Guinevere> returning boolean is unnecessary, since the function can return an Guinevere> optional, and code that calls it can check if the optional contains a Guinevere> value. Nice change, thanks. Guinevere> - && frame_pc_p Guinevere> + && frame_pc I think gdb normally prefers the explicit check of has_value rather than relying on the conversion to bool. Tom