From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/6] Remove some dead code from buildsym.c
Date: Mon, 20 Apr 2026 08:19:54 -0600 [thread overview]
Message-ID: <871pg9sohh.fsf@tromey.com> (raw)
In-Reply-To: <1ad6165b-d023-4e19-8500-9c6bd5f815a1@simark.ca> (Simon Marchi's message of "Fri, 17 Apr 2026 16:10:53 -0400")
Simon> I wonder if the whole if above is still useful. It seems to me like
Simon> debug readers (pretty much just DWARF nowadays) should not leave a
Simon> function scope open. And I guess that the DWARF reader goes not. I did
Simon> put a gdb_assert_not_reached in there and ran a few tests and it didn't
Simon> trigger. In other words, I wonder if you could remove that if and just
Simon> keep the
Simon> gdb_assert (m_context_stack.empty ());
Makes sense, I did this.
Tom
next prev parent reply other threads:[~2026-04-20 14:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 18:24 [PATCH 0/6] Some buildsym cleanups Tom Tromey
2026-04-17 18:24 ` [PATCH 1/6] Use scoped_restore for dwarf2_cu::list_in_scope Tom Tromey
2026-04-17 18:24 ` [PATCH 2/6] Remove some dead code from buildsym.c Tom Tromey
2026-04-17 20:10 ` Simon Marchi
2026-04-20 14:19 ` Tom Tromey [this message]
2026-04-17 18:24 ` [PATCH 3/6] Remove context_stack::depth Tom Tromey
2026-04-17 18:24 ` [PATCH 4/6] Change pop_context to return a block Tom Tromey
2026-04-17 20:11 ` Simon Marchi
2026-04-20 14:09 ` Tom Tromey
2026-04-20 14:20 ` Tom Tromey
2026-04-17 18:24 ` [PATCH 5/6] Return void from buildsym_compunit::push_context Tom Tromey
2026-04-17 20:22 ` Simon Marchi
2026-04-20 14:11 ` Tom Tromey
2026-04-17 18:24 ` [PATCH 6/6] Rename context_stack and make it private Tom Tromey
2026-04-17 20:24 ` [PATCH 0/6] Some buildsym cleanups Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pg9sohh.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox