Re: [PATCH 4/6] Change pop_context to return a block

[Tom Tromey <tromey@adacore.com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> My understanding is that the "current" locals and local_using_directives
Simon> vectors are not held in m_context_stack, they are held in these
Simon> m_local_symbols and m_local_using_directives fields.  An entry in
Simon> m_context_stack is a saved context, to be restored later.  I wonder if
Simon> it would simplify the code if we removed m_local_symbols and
Simon> m_local_using_directives, and said that the topmost m_context_stack
Simon> entry holds the current locals and local_using_directives.  That would
Simon> mean pushing an initial context_stack entry for the global scope, I
Simon> guess?

Simon> We wouldn't need moving in and out of m_local_symbols and
Simon> m_local_using_directives anymore.  I don't think it would simplify that
Simon> much in terms of number of lines, but it might make the code a bit
Simon> easier to follow.  Just something to explore, I think this patch is
Simon> good.

Yeah, this might be a good future change, considering that right now the
stack is incoherent: the current function is stored in the stack entry
but other things are not.

I had considered this but I didn't really feel like making the change
and then debugging the inevitable bug I'd introduce.  I.e., I wanted to
keep this series relatively straightforward.

Tom