Re: [PATCH 0/6] Some buildsym cleanups

[Simon Marchi <simark@simark.ca>]

On 4/17/26 2:24 PM, Tom Tromey wrote:
> This patch series cleans up buildsym a bit, in particular the context
> pushing and popping code.
> 
> Regression tested on x86-64 Fedora 43.
> 
> Signed-off-by: Tom Tromey <tromey@adacore.com>
> ---
> Tom Tromey (6):
>       Use scoped_restore for dwarf2_cu::list_in_scope
>       Remove some dead code from buildsym.c
>       Remove context_stack::depth
>       Change pop_context to return a block
>       Return void from buildsym_compunit::push_context
>       Rename context_stack and make it private
> 
>  gdb/buildsym.c    |  58 +++++++++++++------------------
>  gdb/buildsym.h    | 100 ++++++++++++++++++++++++++++++------------------------
>  gdb/dwarf2/cu.h   |   7 +---
>  gdb/dwarf2/read.c |  82 +++++++++++++++-----------------------------
>  4 files changed, 108 insertions(+), 139 deletions(-)
> ---
> base-commit: bfd118583ed69db365265915d1a48eb719e997f5
> change-id: 20260417-list-in-scope-4242b4cf355b
> 
> Best regards,
> -- 
> Tom Tromey <tromey@adacore.com>
> 

I provided some ideas for possible future improvements, but I think that
this series is a clear step forward, and I would hate to delay this, and
any improvement can be made in subsequent patches.  So:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon