From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id seJEGC6X4mm2PSAAWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 16:25:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776457518; bh=ei1lApRDj9xB8NYIJMIOVOoaxihobfLKNx0QYa4YD50=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=tArzFl5uoPq7YDru72KxEtGnwzOxtzNEBdRrzIBJ0iDKgacoj72vZY8Pf2iTkCQRT MtmO74dGoiz91XHWQCv649Pces7czoZZBfC598O/G6svv24NEp/Qk9iIZpF+kJLMeq mSW02MQFHY87ZOkeHUscTjo/Vziy/1H7/kQ//Vmw= Received: by simark.ca (Postfix, from userid 112) id 520491E04F; Fri, 17 Apr 2026 16:25:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=AjJYwVre; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C9AC51E04F for ; Fri, 17 Apr 2026 16:25:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 532194D108D5 for ; Fri, 17 Apr 2026 20:25:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 532194D108D5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=AjJYwVre Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7A5EE4C900C5 for ; Fri, 17 Apr 2026 20:24:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A5EE4C900C5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7A5EE4C900C5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776457490; cv=none; b=g1JhDV/6BY5YwrP4GsgfsRjOVYuJtS9M27gI8Q7G9QtwOUR9vzrPdOAAvLzN5AHa1HWRLWWB5RYa4R38q/gIXWMmJQzO8IuRpfBsm7ol2Dlhxolxh/8+8K0liM42yWOjzlHdOSIxFiHoiB+i7hAmRjxee6QfjaslZsiT/VcypB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776457490; c=relaxed/simple; bh=ei1lApRDj9xB8NYIJMIOVOoaxihobfLKNx0QYa4YD50=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Pm3zJgmRbTF+Tzx7PfjW7Eg7gRkVgy5y0PpoJqiynJ68Yy0+nTJPu+AcvU9wVcYbXdS93XcQnWeNHXw7V4lli+xMFKtXJLVwXK4JLlz5hpGj77o4C0z8IdADQstaOCyF9T2imYCRy/jhHe8V/tg8OrzcP/k1EqaWT/c2pfDZ8yA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A5EE4C900C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776457489; bh=ei1lApRDj9xB8NYIJMIOVOoaxihobfLKNx0QYa4YD50=; h=Date:Subject:To:References:From:In-Reply-To:From; b=AjJYwVrecc1Wk5PyfpkmWG69XtOmRuP+7VBseFLQNoK5cNkCbDnOJcnlx3Mszr0DB D5eyUes5t+5XnvhOKldc7AX+b3dJ70L+8s9bF9efnZUncT3crzMFSsiEAHfPrGi8tS uiy6CNwLE7jYXoH0Zbmwae0IK5Aa6KmFF2X3AGTk= Received: by simark.ca (Postfix) id AB6AD1E04F; Fri, 17 Apr 2026 16:24:48 -0400 (EDT) Message-ID: <2340b276-38fc-42e0-821e-5923992d6fac@simark.ca> Date: Fri, 17 Apr 2026 16:24:48 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/6] Some buildsym cleanups To: Tom Tromey , gdb-patches@sourceware.org References: <20260417-list-in-scope-v1-0-0deb050fc03d@adacore.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260417-list-in-scope-v1-0-0deb050fc03d@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/17/26 2:24 PM, Tom Tromey wrote: > This patch series cleans up buildsym a bit, in particular the context > pushing and popping code. > > Regression tested on x86-64 Fedora 43. > > Signed-off-by: Tom Tromey > --- > Tom Tromey (6): > Use scoped_restore for dwarf2_cu::list_in_scope > Remove some dead code from buildsym.c > Remove context_stack::depth > Change pop_context to return a block > Return void from buildsym_compunit::push_context > Rename context_stack and make it private > > gdb/buildsym.c | 58 +++++++++++++------------------ > gdb/buildsym.h | 100 ++++++++++++++++++++++++++++++------------------------ > gdb/dwarf2/cu.h | 7 +--- > gdb/dwarf2/read.c | 82 +++++++++++++++----------------------------- > 4 files changed, 108 insertions(+), 139 deletions(-) > --- > base-commit: bfd118583ed69db365265915d1a48eb719e997f5 > change-id: 20260417-list-in-scope-4242b4cf355b > > Best regards, > -- > Tom Tromey > I provided some ideas for possible future improvements, but I think that this series is a clear step forward, and I would hate to delay this, and any improvement can be made in subsequent patches. So: Approved-By: Simon Marchi Simon