From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ASs3ByU25mllrSwAWB0awg (envelope-from ) for ; Mon, 20 Apr 2026 10:20:21 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=RSS9c/mO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 188721E0BA; Mon, 20 Apr 2026 10:20:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 706681E067 for ; Mon, 20 Apr 2026 10:20:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 070214D108DE for ; Mon, 20 Apr 2026 14:20:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 070214D108DE Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=RSS9c/mO Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id 266D84BA2E0B for ; Mon, 20 Apr 2026 14:19:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 266D84BA2E0B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 266D84BA2E0B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::235 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776694797; cv=none; b=cuSx8TyiUe/EIsqhjZUSzVhCE07WfJw8MwHcC0vvYsrHw+cri4NFcfIsggNx88YtfVYczBhGbQjXhYKmG67FPpxICFGMd99WXwFxtQ56IBqlVjGgX25wBfSaFIFWbh+3JHyKA7qtypAOAo9W3ybERtGQkmHWq9pXoOQPCfwcA5c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776694797; c=relaxed/simple; bh=qvoy9quCxyZ8xt/w3Wm+7TA5p+4WbXWcGa7Dnvnaelc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cSzAtOa5Lz9DKJMY8T7eHo0xOIGR7uMRdTUrJYvlHJumSbtSoJtiTmUkr3OVIjzifYNksnhcW9yN2dgzLxmOWU5VAQFIGoH9NXxJqBxxUw/HT5ndgElC7nxoYjgks2csG+6Fe61qcIDpmL+DqBd8+SdmpbAZUucpMRsTw+m5Dcg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 266D84BA2E0B Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-45f053b7b90so1769680b6e.0 for ; Mon, 20 Apr 2026 07:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1776694796; x=1777299596; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=F80sBIB5sSmGAYJjk1cyk+2uuTFPfyEG+RFcab9js9g=; b=RSS9c/mO6kcw4DFXFrrdVfGcT0ZL1HC7sfmNsNvomEPhTJzRXTqSwWP3hy95bYSdjj oGRliEF+XpvjRcaWRy6lwGC2zntsQW1B9I2kDfNGyiNN66XV3JQ0sjSIj8s3n3IZSS9i I4Its3dM81yvyRkdE5EKhApplm2CA24PN+GdhDRbxAqLtqTv4gldiPjGzP46Xbbo1yQE ZFFeQxG/CgzGIWKsVji5FxJukABuieX/tTXTbpHymUFU42eU/fnE5dPZ+3zm3os9BmZd Wxo3rkvO5r5fewe6kGxzLUcPSeZ6kabvus0tOcfoAhZHD0aSQAwJPyP7aMPRGEvw6yfR VnFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776694796; x=1777299596; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=F80sBIB5sSmGAYJjk1cyk+2uuTFPfyEG+RFcab9js9g=; b=Gg+4Gipekk5OzT++pXk74YL4vQoxCGOzyTgX8Z09LQ9tpzp73odsXW5AadxvOYJRZL nrbEl2VYLzS2+Zu5FtTXXmh8FXxwzs7MvgVF+ouT1JcHzc7CxeyxlXUYyYPp3gZPhuhn QgK32EFMg0I9szDngWERAo7yEL92VN+R6rOiWHLchyCHMNA2Q1dTyyr3labx4xtoAjwl f4poHXsbSSRydYL9RwRSr/ME3Vk3B4CcA9OHD3G5tWJwy19qcOYVRIov6d2gs4d4kXAN OmxTg9H/wUFF0RkhU673Oj717/ny76z7lHQHuJ3fUNmzbdvgXelHuJlu2cF+R75TqXaz 9Kow== X-Forwarded-Encrypted: i=1; AFNElJ+IF79x36Eqbbe5UfznJsswlRVV2auS/3gXEMuYaRTgqmw/Bf2U68K2y2Uss+BOpt4jzD2du91mYHZj+g==@sourceware.org X-Gm-Message-State: AOJu0YyfXPU3ARDvZBpM36COADE23lxSO9o3++3IyKAyFPCn3TOF8xfX niU3XRDtD0TILJIEJVx3j9JCNx4LL6w9cnsXD4rHCz+AmIOLEBpcxUhgeq837l0WPHkugmuDYF4 Waao= X-Gm-Gg: AeBDiev/Y3XKAi1eMvdo4DaVUYH9HVZIP9Tv9U2R6Iig4LPuw4dv7b7/8amyELKKCJz lPRZJOubV+RRAZBddpHi7UmlkMuTMlgzymB3NT0w/J9G43TLAi5vTZlftRGLHnlV57XEcUnK0ZN 89nZDVHtmkEbwqw6jZT9OP3o3FzC2AH7EA+WXGUdhFpXt/GjLo4O7JhSHYztTIa2RbWllaSApUA 5OuCjDApnVai3m6lpJ/0la9Wtd3VhBT5dHqFJAGg0CRKXYXpPcUur+RsdAfdI0j8V63DR9KRKK5 GIur8OzskzK2r/k9wYzb5DAAYjM4bh8acxrQm/lVozlQ25Kom1RHKyh82EgJI6P9zE6H9N38WW2 mvhijxQhrBjMhsJvn0j++Fv2CStTseyxsKTEn92e87Emk9+Low9VSEwSc3voN5RwEtsuiGmHtXe uKUIJyzmkqXQq1+OPrfWEkwkvVPeaRUFgTNJy6ExpZPkgBk8yNtOb0BQ== X-Received: by 2002:a05:6808:d4a:b0:467:49c0:5f6d with SMTP id 5614622812f47-4799ca893f0mr6982875b6e.23.1776694796270; Mon, 20 Apr 2026 07:19:56 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-42c054997absm2170802fac.3.2026.04.20.07.19.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Apr 2026 07:19:55 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/6] Remove some dead code from buildsym.c In-Reply-To: <1ad6165b-d023-4e19-8500-9c6bd5f815a1@simark.ca> (Simon Marchi's message of "Fri, 17 Apr 2026 16:10:53 -0400") References: <20260417-list-in-scope-v1-0-0deb050fc03d@adacore.com> <20260417-list-in-scope-v1-2-0deb050fc03d@adacore.com> <1ad6165b-d023-4e19-8500-9c6bd5f815a1@simark.ca> X-Attribution: Tom Date: Mon, 20 Apr 2026 08:19:54 -0600 Message-ID: <871pg9sohh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon> I wonder if the whole if above is still useful. It seems to me like Simon> debug readers (pretty much just DWARF nowadays) should not leave a Simon> function scope open. And I guess that the DWARF reader goes not. I did Simon> put a gdb_assert_not_reached in there and ran a few tests and it didn't Simon> trigger. In other words, I wonder if you could remove that if and just Simon> keep the Simon> gdb_assert (m_context_stack.empty ()); Makes sense, I did this. Tom