From: Mark Kettenis <kettenis@chello.nl>
To: Richard Henderson <rth@twiddle.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] update alpha return value hooks to regcache
Date: Mon, 02 Jun 2003 16:25:00 -0000 [thread overview]
Message-ID: <86znl08n1j.fsf@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: Richard Henderson's message of "Sun, 1 Jun 2003 22:26:12 -0700"
Richard Henderson <rth@twiddle.net> writes:
> Ok?
>
> r~
>
> * alpha-tdep.c (alpha_extract_return_value): Convert to regcache.
> (alpha_extract_struct_value_address): Likewise.
> (alpha_store_return_value): Likewise.
> (alpha_store_struct_return): Remove.
> (alpha_gdbarch_init): Update hook registration to match.
>
Ah, this one's got a flaw. Using abort() isn't allowed in GDB.
Instead use internal_error() which gives the user the option of
continuing at his/her own risk. You could also use gdb_assert()
(which calls internal_error()).
With that change, this is approved.
Mark
next prev parent reply other threads:[~2003-06-02 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-02 5:26 Richard Henderson
2003-06-02 16:25 ` Mark Kettenis [this message]
2003-06-02 18:40 ` Andrew Cagney
2003-06-02 20:55 ` Richard Henderson
2003-06-02 20:46 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86znl08n1j.fsf@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox