From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-24825-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 32581 invoked by alias); 2 Jun 2003 16:25:01 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32489 invoked from network); 2 Jun 2003 16:24:58 -0000
Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212)
  by sources.redhat.com with SMTP; 2 Jun 2003 16:24:58 -0000
Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2])
	by walton.kettenis.dyndns.org (8.12.6p2/8.12.5) with ESMTP id h52GOvku000921;
	Mon, 2 Jun 2003 18:24:57 +0200 (CEST)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1])
	by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6) with ESMTP id h52GOvv1001154;
	Mon, 2 Jun 2003 18:24:57 +0200 (CEST)
	(envelope-from kettenis@elgar.kettenis.dyndns.org)
Received: (from kettenis@localhost)
	by elgar.kettenis.dyndns.org (8.12.6p2/8.12.6/Submit) id h52GOuQB001151;
	Mon, 2 Jun 2003 18:24:56 +0200 (CEST)
To: Richard Henderson <rth@twiddle.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] update alpha return value hooks to regcache
References: <20030602052612.GA7505@twiddle.net>
From: Mark Kettenis <kettenis@chello.nl>
Date: Mon, 02 Jun 2003 16:25:00 -0000
In-Reply-To: Richard Henderson's message of "Sun, 1 Jun 2003 22:26:12 -0700"
Message-ID: <86znl08n1j.fsf@elgar.kettenis.dyndns.org>
X-SW-Source: 2003-06/txt/msg00069.txt.bz2

Richard Henderson <rth@twiddle.net> writes:

> Ok?
> 
> r~
> 
> 	* alpha-tdep.c (alpha_extract_return_value): Convert to regcache.
> 	(alpha_extract_struct_value_address): Likewise.
> 	(alpha_store_return_value): Likewise.
> 	(alpha_store_struct_return): Remove.
> 	(alpha_gdbarch_init): Update hook registration to match.
>

Ah, this one's got a flaw.  Using abort() isn't allowed in GDB.
Instead use internal_error() which gives the user the option of
continuing at his/her own risk.  You could also use gdb_assert()
(which calls internal_error()).

With that change, this is approved.

Mark