Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] update alpha return value hooks to regcache
Date: Mon, 02 Jun 2003 20:46:00 -0000	[thread overview]
Message-ID: <20030602204624.GA10655@twiddle.net> (raw)
In-Reply-To: <86znl08n1j.fsf@elgar.kettenis.dyndns.org>

On Mon, Jun 02, 2003 at 06:24:56PM +0200, Mark Kettenis wrote:
> Ah, this one's got a flaw.  Using abort() isn't allowed in GDB.

Ok.  Addressed like so.


r~


        * alpha-tdep.c (alpha_extract_return_value): Use internal_error.
        (alpha_store_return_value): Likewise.

Index: alpha-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/alpha-tdep.c,v
retrieving revision 1.102
diff -c -p -d -u -r1.102 alpha-tdep.c
--- alpha-tdep.c	2 Jun 2003 16:18:32 -0000	1.102
+++ alpha-tdep.c	2 Jun 2003 20:37:07 -0000
@@ -438,7 +438,7 @@ alpha_extract_return_value (struct type 
 	  break;
 
 	default:
-	  abort ();
+	  internal_error (__FILE__, __LINE__, "unknown floating point width");
 	}
       break;
 
@@ -462,7 +462,7 @@ alpha_extract_return_value (struct type 
 	  break;
 
 	default:
-	  abort ();
+	  internal_error (__FILE__, __LINE__, "unknown floating point width");
 	}
       break;
 
@@ -517,7 +517,7 @@ alpha_store_return_value (struct type *v
 	  error ("Cannot set a 128-bit long double return value.");
 
 	default:
-	  abort ();
+	  internal_error (__FILE__, __LINE__, "unknown floating point width");
 	}
       break;
 
@@ -542,7 +542,7 @@ alpha_store_return_value (struct type *v
 	  error ("Cannot set a 128-bit long double return value.");
 
 	default:
-	  abort ();
+	  internal_error (__FILE__, __LINE__, "unknown floating point width");
 	}
       break;
 


      parent reply	other threads:[~2003-06-02 20:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-02  5:26 Richard Henderson
2003-06-02 16:25 ` Mark Kettenis
2003-06-02 18:40   ` Andrew Cagney
2003-06-02 20:55     ` Richard Henderson
2003-06-02 20:46   ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030602204624.GA10655@twiddle.net \
    --to=rth@twiddle.net \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox