From: Richard Henderson <rth@twiddle.net>
To: Andrew Cagney <ac131313@redhat.com>
Cc: Mark Kettenis <kettenis@chello.nl>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] update alpha return value hooks to regcache
Date: Mon, 02 Jun 2003 20:55:00 -0000 [thread overview]
Message-ID: <20030602205553.GB10655@twiddle.net> (raw)
In-Reply-To: <3EDB9A05.8050609@redhat.com>
On Mon, Jun 02, 2003 at 02:40:05PM -0400, Andrew Cagney wrote:
> please avoid the fallthrough.
Done.
r~
* alpha-tdep.c (alpha_store_return_value): Avoid switch fallthru.
Index: alpha-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/alpha-tdep.c,v
retrieving revision 1.103
diff -c -p -d -u -r1.103 alpha-tdep.c
--- alpha-tdep.c 2 Jun 2003 20:46:41 -0000 1.103
+++ alpha-tdep.c 2 Jun 2003 20:47:54 -0000
@@ -503,8 +503,8 @@ alpha_store_return_value (struct type *v
{
case 4:
alpha_convert_flt_dbl (raw_buffer, valbuf);
- valbuf = raw_buffer;
- /* FALLTHRU */
+ regcache_cooked_write (regcache, ALPHA_FP0_REGNUM, raw_buffer);
+ break;
case 8:
regcache_cooked_write (regcache, ALPHA_FP0_REGNUM, valbuf);
next prev parent reply other threads:[~2003-06-02 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-02 5:26 Richard Henderson
2003-06-02 16:25 ` Mark Kettenis
2003-06-02 18:40 ` Andrew Cagney
2003-06-02 20:55 ` Richard Henderson [this message]
2003-06-02 20:46 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030602205553.GB10655@twiddle.net \
--to=rth@twiddle.net \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox