From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4894 invoked by alias); 2 Jun 2003 20:55:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4874 invoked from network); 2 Jun 2003 20:55:57 -0000 Received: from unknown (HELO are.twiddle.net) (64.81.246.98) by sources.redhat.com with SMTP; 2 Jun 2003 20:55:57 -0000 Received: from are.twiddle.net (localhost.localdomain [127.0.0.1]) by are.twiddle.net (8.12.8/8.12.8) with ESMTP id h52KtsLH010727; Mon, 2 Jun 2003 13:55:54 -0700 Received: (from rth@localhost) by are.twiddle.net (8.12.8/8.12.8/Submit) id h52Ktrjq010725; Mon, 2 Jun 2003 13:55:53 -0700 X-Authentication-Warning: are.twiddle.net: rth set sender to rth@twiddle.net using -f Date: Mon, 02 Jun 2003 20:55:00 -0000 From: Richard Henderson To: Andrew Cagney Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: [RFA] update alpha return value hooks to regcache Message-ID: <20030602205553.GB10655@twiddle.net> References: <20030602052612.GA7505@twiddle.net> <86znl08n1j.fsf@elgar.kettenis.dyndns.org> <3EDB9A05.8050609@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EDB9A05.8050609@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2003-06/txt/msg00090.txt.bz2 On Mon, Jun 02, 2003 at 02:40:05PM -0400, Andrew Cagney wrote: > please avoid the fallthrough. Done. r~ * alpha-tdep.c (alpha_store_return_value): Avoid switch fallthru. Index: alpha-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/alpha-tdep.c,v retrieving revision 1.103 diff -c -p -d -u -r1.103 alpha-tdep.c --- alpha-tdep.c 2 Jun 2003 20:46:41 -0000 1.103 +++ alpha-tdep.c 2 Jun 2003 20:47:54 -0000 @@ -503,8 +503,8 @@ alpha_store_return_value (struct type *v { case 4: alpha_convert_flt_dbl (raw_buffer, valbuf); - valbuf = raw_buffer; - /* FALLTHRU */ + regcache_cooked_write (regcache, ALPHA_FP0_REGNUM, raw_buffer); + break; case 8: regcache_cooked_write (regcache, ALPHA_FP0_REGNUM, valbuf);