From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7865 invoked by alias); 2 Jun 2003 20:46:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7819 invoked from network); 2 Jun 2003 20:46:27 -0000 Received: from unknown (HELO are.twiddle.net) (64.81.246.98) by sources.redhat.com with SMTP; 2 Jun 2003 20:46:27 -0000 Received: from are.twiddle.net (localhost.localdomain [127.0.0.1]) by are.twiddle.net (8.12.8/8.12.8) with ESMTP id h52KkOLH010696; Mon, 2 Jun 2003 13:46:24 -0700 Received: (from rth@localhost) by are.twiddle.net (8.12.8/8.12.8/Submit) id h52KkO4Q010694; Mon, 2 Jun 2003 13:46:24 -0700 X-Authentication-Warning: are.twiddle.net: rth set sender to rth@twiddle.net using -f Date: Mon, 02 Jun 2003 20:46:00 -0000 From: Richard Henderson To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] update alpha return value hooks to regcache Message-ID: <20030602204624.GA10655@twiddle.net> References: <20030602052612.GA7505@twiddle.net> <86znl08n1j.fsf@elgar.kettenis.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86znl08n1j.fsf@elgar.kettenis.dyndns.org> User-Agent: Mutt/1.4i X-SW-Source: 2003-06/txt/msg00089.txt.bz2 On Mon, Jun 02, 2003 at 06:24:56PM +0200, Mark Kettenis wrote: > Ah, this one's got a flaw. Using abort() isn't allowed in GDB. Ok. Addressed like so. r~ * alpha-tdep.c (alpha_extract_return_value): Use internal_error. (alpha_store_return_value): Likewise. Index: alpha-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/alpha-tdep.c,v retrieving revision 1.102 diff -c -p -d -u -r1.102 alpha-tdep.c --- alpha-tdep.c 2 Jun 2003 16:18:32 -0000 1.102 +++ alpha-tdep.c 2 Jun 2003 20:37:07 -0000 @@ -438,7 +438,7 @@ alpha_extract_return_value (struct type break; default: - abort (); + internal_error (__FILE__, __LINE__, "unknown floating point width"); } break; @@ -462,7 +462,7 @@ alpha_extract_return_value (struct type break; default: - abort (); + internal_error (__FILE__, __LINE__, "unknown floating point width"); } break; @@ -517,7 +517,7 @@ alpha_store_return_value (struct type *v error ("Cannot set a 128-bit long double return value."); default: - abort (); + internal_error (__FILE__, __LINE__, "unknown floating point width"); } break; @@ -542,7 +542,7 @@ alpha_store_return_value (struct type *v error ("Cannot set a 128-bit long double return value."); default: - abort (); + internal_error (__FILE__, __LINE__, "unknown floating point width"); } break;