From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix PR threads/19422 - show which thread caused stop
Date: Thu, 14 Jan 2016 16:04:00 -0000 [thread overview]
Message-ID: <86si20tael.fsf@gmail.com> (raw)
In-Reply-To: <1451950202-18024-1-git-send-email-palves@redhat.com> (Pedro Alves's message of "Mon, 4 Jan 2016 23:30:02 +0000")
Pedro Alves <palves@redhat.com> writes:
> gdb/ChangeLog:
> 2016-01-04 Pedro Alves <palves@redhat.com>
>
> * break-catch-sig.c (signal_catchpoint_print_it): Use
> maybe_print_thread_hit_breakpoint.
> * break-catch-syscall.c (print_it_catch_syscall): Likewise.
> * break-catch-throw.c (print_it_exception_catchpoint): Likewise.
> * breakpoint.c (maybe_print_thread_hit_breakpoint): New function.
> (print_it_catch_fork, print_it_catch_vfork, print_it_catch_solib)
> (print_it_catch_exec, print_it_ranged_breakpoint)
> (print_it_watchpoint, print_it_masked_watchpoint, bkpt_print_it):
> Use maybe_print_thread_hit_breakpoint.
> * breakpoint.h (maybe_print_thread_hit_breakpoint): Declare.
> * gdbthread.h (show_thread_that_caused_stop): Declare.
> * infrun.c (print_signal_received_reason): Print which thread
> received signal.
> * thread.c (show_thread_that_caused_stop): New function.
>
> gdb/testsuite/ChangeLog:
> 2016-01-04 Pedro Alves <palves@redhat.com>
>
> * gdb.base/async-shell.exp: Adjust expected output.
> * gdb.base/dprintf-non-stop.exp: Adjust expected output.
> * gdb.base/siginfo-thread.exp
> * gdb.base/watchpoint-hw-hit-once.exp
> * gdb.java/jnpe.exp
> * gdb.threads/clone-new-thread-event.exp
> * gdb.threads/continue-pending-status.exp
> * gdb.threads/leader-exit.exp
> * gdb.threads/manythreads.exp
> * gdb.threads/pthreads.exp
> * gdb.threads/schedlock.exp
> * gdb.threads/siginfo-threads.exp
> * gdb.threads/signal-command-multiple-signals-pending.exp
> * gdb.threads/signal-delivered-right-thread.exp
> * gdb.threads/sigthread.exp
> * gdb.threads/watchpoint-fork.exp
"Likewise" is missing for these changed files in ChangeLog. Patch looks
good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-01-14 16:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 23:30 Pedro Alves
2016-01-14 14:08 ` [PATCH+doc] " Pedro Alves
2016-01-14 16:36 ` Eli Zaretskii
2016-01-14 17:12 ` Pedro Alves
2016-01-14 18:25 ` Eli Zaretskii
2016-01-14 19:00 ` Pedro Alves
2016-01-14 19:06 ` Eli Zaretskii
2016-01-18 15:17 ` Pedro Alves
2016-01-22 16:44 ` Jan Kratochvil
2016-01-22 16:55 ` Pedro Alves
2016-01-22 16:56 ` Jan Kratochvil
2016-01-22 17:30 ` [testsuite patch] Fix PR threads/19422 regression + Guile regression [Re: [PATCH+doc] Fix PR threads/19422 - show which thread caused stop] Jan Kratochvil
2016-01-22 17:31 ` [testsuite patch]#2 " Jan Kratochvil
2016-01-22 18:18 ` [testsuite patch]#3 " Jan Kratochvil
2016-01-22 18:37 ` [testsuite patch]#2 " Pedro Alves
2016-01-22 20:05 ` Jan Kratochvil
2016-01-22 20:11 ` Pedro Alves
2016-01-22 20:17 ` Pedro Alves
2016-01-22 20:25 ` [commit] " Jan Kratochvil
2016-01-22 20:44 ` Pedro Alves
2016-01-22 20:51 ` [commit#2] " Jan Kratochvil
2016-01-22 20:53 ` Pedro Alves
2016-01-14 16:04 ` Yao Qi [this message]
2016-01-18 15:24 ` [PATCH] Fix PR threads/19422 - show which thread caused stop Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86si20tael.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox