Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [testsuite patch]#2 Fix PR threads/19422 regression + Guile regression [Re: [PATCH+doc] Fix PR threads/19422 - show which thread caused stop]
Date: Fri, 22 Jan 2016 20:17:00 -0000	[thread overview]
Message-ID: <56A28E40.205@redhat.com> (raw)
In-Reply-To: <56A28CE6.3090406@redhat.com>

On 01/22/2016 08:11 PM, Pedro Alves wrote:
> On 01/22/2016 08:05 PM, Jan Kratochvil wrote:

>> racy case #2:
>>
>> (xgdb) PASS: gdb.gdb/selftest.exp: Set xgdb_prompt
>> ^M
>> Thread 1 "xgdb" received signal SIGINT, Interrupt.^M
>> 0x00007ffff583bfdd in poll () from /lib64/libc.so.6^M
>> (gdb) FAIL: gdb.gdb/selftest.exp: send ^C to child process
>> signal SIGINT^M
>> Continuing with signal SIGINT.^M
>> ^C^M
>> Thread 2 "xgdb" received signal SIGINT, Interrupt.^M
>> [Switching to Thread 0x7ffff3b7f700 (LWP 13227)]^M
> 
> So you need to adjust your patch in the bit that matched
> "Thread 1", right?

And I notice now that this expects the thread name to be the
the program name:

 -	    -re "Program received signal SIGINT.*$gdb_prompt $" {
 +	    -re "(Thread 1 \"xgdb\"|Program) received signal SIGINT.*$gdb_prompt $" {

Not all targets support thread names, and even those that do, not all
use the program name as default thread name -- I think that's only true
for GNU/Linux, actually.  So I think it's best to not expect that, like:

 	    -re "(Thread .*|Program) received signal SIGINT.*$gdb_prompt $" {
or:
	    -re " received signal SIGINT.*$gdb_prompt $" {

Thanks,
Pedro Alves


  reply	other threads:[~2016-01-22 20:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 23:30 [PATCH] Fix PR threads/19422 - show which thread caused stop Pedro Alves
2016-01-14 14:08 ` [PATCH+doc] " Pedro Alves
2016-01-14 16:36   ` Eli Zaretskii
2016-01-14 17:12     ` Pedro Alves
2016-01-14 18:25       ` Eli Zaretskii
2016-01-14 19:00         ` Pedro Alves
2016-01-14 19:06           ` Eli Zaretskii
2016-01-18 15:17             ` Pedro Alves
2016-01-22 16:44   ` Jan Kratochvil
2016-01-22 16:55     ` Pedro Alves
2016-01-22 16:56       ` Jan Kratochvil
2016-01-22 17:30   ` [testsuite patch] Fix PR threads/19422 regression + Guile regression [Re: [PATCH+doc] Fix PR threads/19422 - show which thread caused stop] Jan Kratochvil
2016-01-22 17:31     ` [testsuite patch]#2 " Jan Kratochvil
2016-01-22 18:18       ` [testsuite patch]#3 " Jan Kratochvil
2016-01-22 18:37       ` [testsuite patch]#2 " Pedro Alves
2016-01-22 20:05         ` Jan Kratochvil
2016-01-22 20:11           ` Pedro Alves
2016-01-22 20:17             ` Pedro Alves [this message]
2016-01-22 20:25               ` [commit] " Jan Kratochvil
2016-01-22 20:44                 ` Pedro Alves
2016-01-22 20:51                   ` [commit#2] " Jan Kratochvil
2016-01-22 20:53                     ` Pedro Alves
2016-01-14 16:04 ` [PATCH] Fix PR threads/19422 - show which thread caused stop Yao Qi
2016-01-18 15:24   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A28E40.205@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox