Re: [PATCH+doc] Fix PR threads/19422 - show which thread caused stop

[Pedro Alves <palves@redhat.com>]

On 01/22/2016 04:44 PM, Jan Kratochvil wrote:
> On Thu, 14 Jan 2016 15:08:40 +0100, Pedro Alves wrote:
> [...]
>> 	* gdb.base/watchpoint-hw-hit-once.exp: Adjust expected output.
> [...]
>> diff --git a/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.exp b/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.exp
>> index 5c1be00..46d5c62 100644
>> --- a/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.exp
>> +++ b/gdb/testsuite/gdb.base/watchpoint-hw-hit-once.exp
>> @@ -31,7 +31,7 @@ gdb_test "rwatch watchee"
>>  
>>  gdb_breakpoint [gdb_get_line_number "dummy = 2"]
>>  
>> -gdb_test "continue" "Continuing.\r\nHardware read watchpoint \[0-9\]+: watchee\r\n\r\nValue = 0\r\n.*"
>> +gdb_test "continue" "Continuing.\r\n\r\nHardware read watchpoint \[0-9\]+: watchee\r\n\r\nValue = 0\r\n.*"
> 
> I haven't seen a comment why such change is necessary.  It probably happens
> from some of the changes involved but not sure if it was really required.

Previously, all breakpoint hits had that extra line, except watchpoints.

The patch made every breakpoint kind call the same function to
print the breakpoint hit, which had the side effect of making that inconsistency
disappear.  That is, before we had:

 (gdb) c
 Continuing.

 Breakpoint 2, thread_function0 (arg=0x0) at /home/pedro/gdb/tests/threads.c:87
 87              int_return ();

 (gdb) c
 Continuing.
 Hardware watchpoint 4: args[i]

 Old value = 0
 New value = 1
 main () at /home/pedro/gdb/tests/threads.c:57
 57          res = pthread_create(&threads[i],

Now watchpoint hits are consistent with all other breakpoints in that aspect:

 (gdb) c
 Continuing.

 Hardware watchpoint 2: args[i]

 Old value = 0
 New value = 1
 main () at /home/pedro/gdb/tests/threads.c:57
 57          res = pthread_create(&threads[i],

Thanks,
Pedro Alves