From: Eli Zaretskii <eliz@gnu.org>
To: guoshengyuan1 <guoshengyuan1@xiaomi.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/python]: add the orginal_value field in RegisterChangedEvent
Date: Sun, 28 Sep 2025 15:09:08 +0300 [thread overview]
Message-ID: <86qzvq6aor.fsf@gnu.org> (raw)
In-Reply-To: <20250928111808.271065-1-guoshengyuan1@xiaomi.com> (message from guoshengyuan1 on Sun, 28 Sep 2025 19:18:08 +0800)
> From: guoshengyuan1 <guoshengyuan1@xiaomi.com>
> CC: guoshengyuan1 <guoshengyuan1@xiaomi.com>
> Date: Sun, 28 Sep 2025 19:18:08 +0800
>
> When the register_changed event is triggered, the user should be told
> what the previous value was so they can make a decision, rather
> than just being told what the modified value is.
>
> Signed-off-by: guoshengyuan1 <guoshengyuan1@xiaomi.com>
> ---
> gdb/doc/python.texi | 3 +++
> gdb/observable.h | 4 +++-
> gdb/python/py-event.h | 2 +-
> gdb/python/py-inferior.c | 6 ++++--
> gdb/python/py-infevents.c | 19 ++++++++++++++++---
> gdb/testsuite/gdb.python/py-events.py | 1 +
> gdb/tui/tui-hooks.c | 4 +++-
> gdb/valops.c | 4 +++-
> 8 files changed, 34 insertions(+), 9 deletions(-)
Thanks, the python.texi part is okay.
Should this be called out in NEWS as well?
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2025-09-28 12:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 11:18 guoshengyuan1
2025-09-28 12:09 ` Eli Zaretskii [this message]
2025-09-29 4:23 ` [External Mail]Re: " 郭胜元
2025-09-29 11:09 ` Eli Zaretskii
2025-09-28 15:59 ` Andrew Burgess
2025-09-29 7:47 ` [External Mail]Re: " 郭胜元
2025-10-06 16:01 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86qzvq6aor.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=guoshengyuan1@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox