Re: [External Mail]Re: [PATCH] [gdb/python]: add the orginal_value field in RegisterChangedEvent

[Eli Zaretskii <eliz@gnu.org>]

> From: 郭胜元 <guoshengyuan1@xiaomi.com>
> CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Mon, 29 Sep 2025 04:23:43 +0000
> 
> 在 2025/9/28 20:09, Eli Zaretskii 写道: 
> 
>  From: guoshengyuan1 <guoshengyuan1@xiaomi.com>
> CC: guoshengyuan1 <guoshengyuan1@xiaomi.com>
> Date: Sun, 28 Sep 2025 19:18:08 +0800
> 
> When the register_changed event is triggered, the user should be told
> what the previous value was so they can make a decision, rather
> than just being told what the modified value is.
> 
> Signed-off-by: guoshengyuan1 <guoshengyuan1@xiaomi.com>
> ---
>  gdb/doc/python.texi                   |  3 +++
>  gdb/observable.h                      |  4 +++-
>  gdb/python/py-event.h                 |  2 +-
>  gdb/python/py-inferior.c              |  6 ++++--
>  gdb/python/py-infevents.c             | 19 ++++++++++++++++---
>  gdb/testsuite/gdb.python/py-events.py |  1 +
>  gdb/tui/tui-hooks.c                   |  4 +++-
>  gdb/valops.c                          |  4 +++-
>  8 files changed, 34 insertions(+), 9 deletions(-)
> 
> 
> Thanks, the python.texi part is okay.
> 
> Should this be called out in NEWS as well?
> 
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> 
> What you said makes sense. I think this API change should be mentioned in the NEWS. Do I need to write
> the NEWS?

Yes, please.