Re: [External Mail]Re: [PATCH] [gdb/python]: add the orginal_value field in RegisterChangedEvent

[郭胜元 <guoshengyuan1@xiaomi.com>]

[-- Attachment #1: Type: text/plain, Size: 2108 bytes --]

在 2025/9/28 20:09, Eli Zaretskii 写道:

From: guoshengyuan1 <guoshengyuan1@xiaomi.com><mailto:guoshengyuan1@xiaomi.com>
CC: guoshengyuan1 <guoshengyuan1@xiaomi.com><mailto:guoshengyuan1@xiaomi.com>
Date: Sun, 28 Sep 2025 19:18:08 +0800

When the register_changed event is triggered, the user should be told
what the previous value was so they can make a decision, rather
than just being told what the modified value is.

Signed-off-by: guoshengyuan1 <guoshengyuan1@xiaomi.com><mailto:guoshengyuan1@xiaomi.com>
---
 gdb/doc/python.texi                   |  3 +++
 gdb/observable.h                      |  4 +++-
 gdb/python/py-event.h                 |  2 +-
 gdb/python/py-inferior.c              |  6 ++++--
 gdb/python/py-infevents.c             | 19 ++++++++++++++++---
 gdb/testsuite/gdb.python/py-events.py |  1 +
 gdb/tui/tui-hooks.c                   |  4 +++-
 gdb/valops.c                          |  4 +++-
 8 files changed, 34 insertions(+), 9 deletions(-)



Thanks, the python.texi part is okay.

Should this be called out in NEWS as well?

Reviewed-By: Eli Zaretskii <eliz@gnu.org><mailto:eliz@gnu.org>


What you said makes sense. I think this API change should be mentioned in the NEWS. Do I need to write the NEWS?

#/******本邮件及其附件含有小米公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!******/#

[-- Attachment #2: Type: text/html, Size: 2872 bytes --]