From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6zoeGz9p2mhVUBgAWB0awg (envelope-from ) for ; Mon, 29 Sep 2025 07:10:55 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=EDSMKpyv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5E4C11E0BA; Mon, 29 Sep 2025 07:10:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0D87F1E047 for ; Mon, 29 Sep 2025 07:10:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6AB1C3857354 for ; Mon, 29 Sep 2025 11:10:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6AB1C3857354 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=EDSMKpyv Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 981E63857823 for ; Mon, 29 Sep 2025 11:10:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 981E63857823 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 981E63857823 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759144223; cv=none; b=EMhzuDiu2ZGHtAibCgtqgL6bKx+6gK6TxV06RMhbWbsghe7CFFQJTqwQ+1rOaxLLda16BNPoA007WF6C4h1St/j5Nxk1/vDTG7T8j4bblbTQPZZ2JZrz7O9MrqmCh6aLZWn93Ufl92a6iHwkk9iM9c0XGlEVrUVnFqCMwR1MjqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759144223; c=relaxed/simple; bh=+Rr/T2igRA2G/XaYYqUn/427E27btBWkGu9IUcMb37w=; h=DKIM-Signature:Date:Message-Id:From:To:Subject:MIME-version; b=NB61v89aV/a9Fnzqi4oiYMX6fsN8s+ZCtWItFzNnSpNx1mVKIfguS7h/7q4WmN35oT5gBaAnQF9eJjiHVm3JL1GowABpesGiI13QpY4D+xDGtaSfsX5aWFNe8He4v+x8BrTYQE/vc1KBkRCQXZqW3L2z5FCZVRz5sHPkV1Ojrv4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 981E63857823 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3Blt-0005jX-1h; Mon, 29 Sep 2025 07:10:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=T+L4IJyhZtSEELQrndk2wW5je4gAgAmkaTkwf/r0zks=; b=EDSMKpyvKq8MYYsepKPi +/HXZSfAcWaHztPlJ2vKUv5hz/CN+HqbOgCrp9Io0joowA8QWtrSclu86K/WOe/ds2axj5z5aNlVH qzABvlHS34Sez1USOzK7gPAymzmADfrf/daToR7FktffdrQAWbnIdDyPzq3R8LPyJMkNQnAT8yAtQ H59GAsSg6e1uRmHsa6874g7Zz8WKmsnuntJ+emYIu1Jh0OBcaRL6oPJiJ7yuwkkSZJy2VLfNGfCJi vXEo3+PGWtJB6e3sHKp5BABQ3rbRlQjy0pFoumvYiyqIxtl14ByVP4vvVa9S+vDO2MxeM7Qd432Xe pxfPejf/isE1XA==; Date: Mon, 29 Sep 2025 14:09:47 +0300 Message-Id: <868qhx5xc4.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?6YOt6IOc5YWD?= Cc: gdb-patches@sourceware.org In-Reply-To: (message from =?utf-8?B?6YOt6IOc5YWD?= on Mon, 29 Sep 2025 04:23:43 +0000) Subject: Re: [External Mail]Re: [PATCH] [gdb/python]: add the orginal_value field in RegisterChangedEvent References: <20250928111808.271065-1-guoshengyuan1@xiaomi.com> <86qzvq6aor.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: 郭胜元 > CC: "gdb-patches@sourceware.org" > Date: Mon, 29 Sep 2025 04:23:43 +0000 > > 在 2025/9/28 20:09, Eli Zaretskii 写道: > > From: guoshengyuan1 > CC: guoshengyuan1 > Date: Sun, 28 Sep 2025 19:18:08 +0800 > > When the register_changed event is triggered, the user should be told > what the previous value was so they can make a decision, rather > than just being told what the modified value is. > > Signed-off-by: guoshengyuan1 > --- > gdb/doc/python.texi | 3 +++ > gdb/observable.h | 4 +++- > gdb/python/py-event.h | 2 +- > gdb/python/py-inferior.c | 6 ++++-- > gdb/python/py-infevents.c | 19 ++++++++++++++++--- > gdb/testsuite/gdb.python/py-events.py | 1 + > gdb/tui/tui-hooks.c | 4 +++- > gdb/valops.c | 4 +++- > 8 files changed, 34 insertions(+), 9 deletions(-) > > > Thanks, the python.texi part is okay. > > Should this be called out in NEWS as well? > > Reviewed-By: Eli Zaretskii > > What you said makes sense. I think this API change should be mentioned in the NEWS. Do I need to write > the NEWS? Yes, please.