From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id N9grEJAl2WhWNhcAWB0awg (envelope-from ) for ; Sun, 28 Sep 2025 08:09:52 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=GUx3ADlv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 30D451E047; Sun, 28 Sep 2025 08:09:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6B1991E047 for ; Sun, 28 Sep 2025 08:09:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AFC79385828E for ; Sun, 28 Sep 2025 12:09:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AFC79385828E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=GUx3ADlv Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1C0F93858CD1 for ; Sun, 28 Sep 2025 12:09:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C0F93858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C0F93858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759061359; cv=none; b=q6eApweJKTZTRpv/78TBUcpAPPyRiKoTeOOkBZg0olspM56mzG1GI+QQwS7Ctmk4uqtw5pPprutf72OXiBVSU9b36vbRovEirYMFVOGLs6IMZSTffHJLUqRKW5lnWjbozhzsA5/tR1tGtj6lY1arGVTPi443T1ZREAfzN80uMeo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759061359; c=relaxed/simple; bh=y4H4DxEMQVLbWmgl3KP65shiiu9Few6v29IIi//aZgU=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=rEigtUQ2HMgilvdKvRsOC9HfWOqPPMH3xldOUHqNAH9IvFf7o57vWZuKyaZepiZBa+h4oL/3lb2TLPB2kwomOwDqCwa4oqc5m5PQBO+++BrVz+kTAx7Db//JWc9nvX5HRGVhCyWdOhlcCBwGifyKVBde1duWtp41J/wh9aTbihI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C0F93858CD1 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v2qDL-0006vo-VQ; Sun, 28 Sep 2025 08:09:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=q8SGUO4IEFkET8LV//qynDY9Tgf8HC78W82RquPBxN8=; b=GUx3ADlvbHA5 QsX4WeTpGiCme1VVql+zgAnhgHOo/6qDdPwPp2/c+duYlGqrawEJnumpoHIMSpA59AJSo/oaU4SWZ x0Ky0c3iHktk345f0jjmtm2TJiqQ2xekyNbSHMYi0TP2OtPnr9+tEQLLM6Jqj/62BVlf2scXanrzE nT7RkS1UgSPN9xeq2iHcaQw3e80bNBygU8TzPxAjU8LblYG6xszaN3OJvPJxbCURJ2c+whjTZGMDn NjLMSSn/Za/Zbphl/1L4wjQDXGwBngoEI+foeKB1FWKlUXWOBXYHvQ/cmusqu2WzL2cU/0ztdHzdm 33eD212w4g+3pUZ/EfmXCA==; Date: Sun, 28 Sep 2025 15:09:08 +0300 Message-Id: <86qzvq6aor.fsf@gnu.org> From: Eli Zaretskii To: guoshengyuan1 Cc: gdb-patches@sourceware.org In-Reply-To: <20250928111808.271065-1-guoshengyuan1@xiaomi.com> (message from guoshengyuan1 on Sun, 28 Sep 2025 19:18:08 +0800) Subject: Re: [PATCH] [gdb/python]: add the orginal_value field in RegisterChangedEvent References: <20250928111808.271065-1-guoshengyuan1@xiaomi.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: guoshengyuan1 > CC: guoshengyuan1 > Date: Sun, 28 Sep 2025 19:18:08 +0800 > > When the register_changed event is triggered, the user should be told > what the previous value was so they can make a decision, rather > than just being told what the modified value is. > > Signed-off-by: guoshengyuan1 > --- > gdb/doc/python.texi | 3 +++ > gdb/observable.h | 4 +++- > gdb/python/py-event.h | 2 +- > gdb/python/py-inferior.c | 6 ++++-- > gdb/python/py-infevents.c | 19 ++++++++++++++++--- > gdb/testsuite/gdb.python/py-events.py | 1 + > gdb/tui/tui-hooks.c | 4 +++- > gdb/valops.c | 4 +++- > 8 files changed, 34 insertions(+), 9 deletions(-) Thanks, the python.texi part is okay. Should this be called out in NEWS as well? Reviewed-By: Eli Zaretskii