Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: gdb-patches@sourceware.org,  qiyaoltc@gmail.com
Subject: Re: [PATCH] Don't throw an error in "show mpx bound" implementation
Date: Mon, 06 Jul 2015 09:31:00 -0000	[thread overview]
Message-ID: <86oajpocn3.fsf@gmail.com> (raw)
In-Reply-To: <1435853930-32119-1-git-send-email-patrick@parcs.ath.cx> (Patrick	Palka's message of "Thu, 2 Jul 2015 12:18:50 -0400")

Patrick Palka <patrick@parcs.ath.cx> writes:

> "show" functions should not throw an exception in part because it causes
> the output of the commands "info set" and "show" to get truncated.
>
> This fixes the following fails:
>
>     FAIL: gdb.base/default.exp: info set
>     FAIL: gdb.base/default.exp: show
>
> gdb/ChangeLog:
>
> 	* i386-tdep.c (i386_mpx_info_bounds): Don't call error, instead
> 	use printf_unfiltered.
> 	(set_mpx_cmd): Add missing trailing space to command string
> 	literal.
> 	(_initialize_i386_tdep): Give the "mpx" prefix command its
> 	correct name.

It looks good to me.  Thanks.

-- 
Yao (齐尧)


  reply	other threads:[~2015-07-06  9:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 18:31 Several regressions and we branch soon Doug Evans
2015-06-23 18:55 ` Patrick Palka
2015-06-23 19:03   ` Doug Evans
2015-06-23 20:17     ` Keith Seitz
2015-06-23 20:53       ` Doug Evans
2015-06-23 21:45         ` Patrick Palka
2015-06-24 11:55           ` Yao Qi
2015-06-25 16:35             ` Tedeschi, Walfred
2015-07-01  8:49               ` Yao Qi
     [not found]                 ` <AC542571535E904D8E8ADAE745D60B1944445D44@IRSMSX104.ger.corp.intel.com>
2015-07-01  9:30                   ` Walfred Tedeschi
2015-07-02 10:09                     ` Yao Qi
2015-07-02 15:34           ` Yao Qi
2015-07-02 16:19             ` [PATCH] Don't throw an error in "show mpx bound" implementation Patrick Palka
2015-07-06  9:31               ` Yao Qi [this message]
2015-06-24 10:21 ` Several regressions and we branch soon Yao Qi
     [not found]   ` <87lhf8yz90.fsf@br87z6lw.de.ibm.com>
2015-06-25 13:34     ` Doug Evans
2015-06-25 18:00       ` Andreas Arnez
2015-06-30 15:21         ` Yao Qi
2015-06-30 18:09           ` Andreas Arnez
2015-07-01  8:01             ` Yao Qi
2015-07-10  9:33             ` Yao Qi
2015-07-10 16:12               ` Andreas Arnez
2015-07-10 16:23                 ` Ulrich Weigand
2015-07-20 15:08                   ` Andreas Arnez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86oajpocn3.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=patrick@parcs.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox