From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85561 invoked by alias); 6 Jul 2015 09:31:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85545 invoked by uid 89); 6 Jul 2015 09:31:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f49.google.com Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 06 Jul 2015 09:31:55 +0000 Received: by pacgz10 with SMTP id gz10so18957062pac.3 for ; Mon, 06 Jul 2015 02:31:53 -0700 (PDT) X-Received: by 10.66.235.199 with SMTP id uo7mr26209881pac.112.1436175113202; Mon, 06 Jul 2015 02:31:53 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id ot3sm17533021pbb.4.2015.07.06.02.31.50 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 06 Jul 2015 02:31:51 -0700 (PDT) From: Yao Qi To: Patrick Palka Cc: gdb-patches@sourceware.org, qiyaoltc@gmail.com Subject: Re: [PATCH] Don't throw an error in "show mpx bound" implementation References: <559559F2.90700@gmail.com> <1435853930-32119-1-git-send-email-patrick@parcs.ath.cx> Date: Mon, 06 Jul 2015 09:31:00 -0000 In-Reply-To: <1435853930-32119-1-git-send-email-patrick@parcs.ath.cx> (Patrick Palka's message of "Thu, 2 Jul 2015 12:18:50 -0400") Message-ID: <86oajpocn3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00114.txt.bz2 Patrick Palka writes: > "show" functions should not throw an exception in part because it causes > the output of the commands "info set" and "show" to get truncated. > > This fixes the following fails: > > FAIL: gdb.base/default.exp: info set > FAIL: gdb.base/default.exp: show > > gdb/ChangeLog: > > * i386-tdep.c (i386_mpx_info_bounds): Don't call error, instead > use printf_unfiltered. > (set_mpx_cmd): Add missing trailing space to command string > literal. > (_initialize_i386_tdep): Give the "mpx" prefix command its > correct name. It looks good to me. Thanks. --=20 Yao (=E9=BD=90=E5=B0=A7)