From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] Add some more casts (1/2)
Date: Fri, 25 Sep 2015 13:17:00 -0000 [thread overview]
Message-ID: <86fv228wpz.fsf@gmail.com> (raw)
In-Reply-To: <1443036644-583-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 23 Sep 2015 15:30:43 -0400")
Simon Marchi <simon.marchi@ericsson.com> writes:
> - const struct signal_catchpoint *c = (void *) bl->owner;
> + const struct signal_catchpoint *c =
> + (const struct signal_catchpoint *) bl->owner;
Nit here: "=" should be put the beginning of next line, like
const struct signal_catchpoint *c
= (const struct signal_catchpoint *) bl->owner;
GNU Coding Standards says "When you split an expression into multiple
lines, split it before an operator, not after one." There are multiple
instances of this problem.
OK with them fixed.
--
Yao (齐尧)
next prev parent reply other threads:[~2015-09-25 13:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 19:31 Simon Marchi
2015-09-23 19:31 ` [PATCH 3/2] Add some more casts (2/2) Simon Marchi
2015-09-25 13:20 ` Yao Qi
2015-09-25 18:19 ` Simon Marchi
2015-09-28 15:45 ` Ulrich Weigand
2015-09-28 17:14 ` Simon Marchi
2015-09-30 14:53 ` Simon Marchi
2015-09-30 15:16 ` Ulrich Weigand
2015-09-30 15:25 ` Simon Marchi
2015-09-25 13:17 ` Yao Qi [this message]
2015-09-25 13:29 ` [PATCH 2/2] Add some more casts (1/2) Simon Marchi
2015-09-25 18:18 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fv228wpz.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox