From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: simon.marchi@ericsson.com (Simon Marchi)
Cc: qiyaoltc@gmail.com (Yao Qi), gdb-patches@sourceware.org
Subject: Re: [PATCH 3/2] Add some more casts (2/2)
Date: Wed, 30 Sep 2015 15:16:00 -0000 [thread overview]
Message-ID: <20150930151607.46D7ADC0@oc7340732750.ibm.com> (raw)
In-Reply-To: <560BF780.30004@ericsson.com> from "Simon Marchi" at Sep 30, 2015 10:53:52 AM
Simon Marchi wrote:
> As reported by Ulrich here:
>
> https://sourceware.org/ml/gdb-patches/2015-09/msg00604.html
>
> The system compiler (gcc 4.1) in Centos 5 doesn't like that we cast to a
> pointer to a type that doesn't exist. I see no real value in using this
> kind iof construct over just using void *. So this patch changes the
> tdep_info field to void * and removes the casts. Even in C++, we
> should not need an explicit cast when assigning to a void *.
>
> gdb/ChangeLog:
>
> * gdbarch.sh (struct gdbarch_info): Change tdep_info's type to void *.
> * gdbarch.h: Regenerate.
> * i386-tdep.c (i386_gdbarch_init): Remove cast to
> struct gdbarch_tdep_info *.
> * mips-tdep.c (mips_gdbarch_init): Likewise.
> * ppc-linux-tdep (ppu2spu_sniffer): Likewise.
> * rs6000-tdep.c (rs6000_gdbarch_init): Likewise.
> * spu-multiarch.c (spu_gdbarch): Likewise.
This is OK, thanks!
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2015-09-30 15:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 19:31 [PATCH 2/2] Add some more casts (1/2) Simon Marchi
2015-09-23 19:31 ` [PATCH 3/2] Add some more casts (2/2) Simon Marchi
2015-09-25 13:20 ` Yao Qi
2015-09-25 18:19 ` Simon Marchi
2015-09-28 15:45 ` Ulrich Weigand
2015-09-28 17:14 ` Simon Marchi
2015-09-30 14:53 ` Simon Marchi
2015-09-30 15:16 ` Ulrich Weigand [this message]
2015-09-30 15:25 ` Simon Marchi
2015-09-25 13:17 ` [PATCH 2/2] Add some more casts (1/2) Yao Qi
2015-09-25 13:29 ` Simon Marchi
2015-09-25 18:18 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930151607.46D7ADC0@oc7340732750.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox