From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67166 invoked by alias); 30 Sep 2015 15:16:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67157 invoked by uid 89); 30 Sep 2015 15:16:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp17.uk.ibm.com Received: from e06smtp17.uk.ibm.com (HELO e06smtp17.uk.ibm.com) (195.75.94.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 30 Sep 2015 15:16:16 +0000 Received: from localhost by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 30 Sep 2015 16:16:12 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp17.uk.ibm.com (192.168.101.147) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 30 Sep 2015 16:16:08 +0100 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: uweigand@de.ibm.com X-IBM-RcptTo: gdb-patches@sourceware.org Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id E0D5717D8042 for ; Wed, 30 Sep 2015 16:18:03 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t8UFG8p341156710 for ; Wed, 30 Sep 2015 15:16:08 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t8UFG7Q5024719 for ; Wed, 30 Sep 2015 09:16:07 -0600 Received: from oc7340732750.ibm.com (dyn-9-152-213-225.boeblingen.de.ibm.com [9.152.213.225]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t8UFG7Io024702; Wed, 30 Sep 2015 09:16:07 -0600 Received: by oc7340732750.ibm.com (Postfix, from userid 500) id 46D7ADC0; Wed, 30 Sep 2015 17:16:07 +0200 (CEST) Subject: Re: [PATCH 3/2] Add some more casts (2/2) To: simon.marchi@ericsson.com (Simon Marchi) Date: Wed, 30 Sep 2015 15:16:00 -0000 From: "Ulrich Weigand" Cc: qiyaoltc@gmail.com (Yao Qi), gdb-patches@sourceware.org In-Reply-To: <560BF780.30004@ericsson.com> from "Simon Marchi" at Sep 30, 2015 10:53:52 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20150930151607.46D7ADC0@oc7340732750.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15093015-0029-0000-0000-000008730900 X-SW-Source: 2015-09/txt/msg00668.txt.bz2 Simon Marchi wrote: > As reported by Ulrich here: > > https://sourceware.org/ml/gdb-patches/2015-09/msg00604.html > > The system compiler (gcc 4.1) in Centos 5 doesn't like that we cast to a > pointer to a type that doesn't exist. I see no real value in using this > kind iof construct over just using void *. So this patch changes the > tdep_info field to void * and removes the casts. Even in C++, we > should not need an explicit cast when assigning to a void *. > > gdb/ChangeLog: > > * gdbarch.sh (struct gdbarch_info): Change tdep_info's type to void *. > * gdbarch.h: Regenerate. > * i386-tdep.c (i386_gdbarch_init): Remove cast to > struct gdbarch_tdep_info *. > * mips-tdep.c (mips_gdbarch_init): Likewise. > * ppc-linux-tdep (ppu2spu_sniffer): Likewise. > * rs6000-tdep.c (rs6000_gdbarch_init): Likewise. > * spu-multiarch.c (spu_gdbarch): Likewise. This is OK, thanks! Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com