Re: [PATCH 2/2] Add some more casts (1/2)

[Simon Marchi <simon.marchi@ericsson.com>]

On 15-09-25 09:17 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
> 
>> -  const struct signal_catchpoint *c = (void *) bl->owner;
>> +  const struct signal_catchpoint *c =
>> +    (const struct signal_catchpoint *) bl->owner;
> 
> Nit here: "=" should be put the beginning of next line, like
> 
>     const struct signal_catchpoint *c
>       = (const struct signal_catchpoint *) bl->owner;
> 
> GNU Coding Standards says "When you split an expression into multiple
> lines, split it before an operator, not after one."  There are multiple
> instances of this problem.
> 
> OK with them fixed.

I saw that, but didn't know that it applied to the assignment operator
as well.  IMO, moving the = to the second line does not improve readability
and potentially causes even more line wrapping.  Anyhow, I'll fix those to
conform to GNU Coding Standards.

Thanks!