From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 404 invoked by alias); 25 Sep 2015 13:29:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 393 invoked by uid 89); 25 Sep 2015 13:29:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 25 Sep 2015 13:29:37 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id F4.24.26730.DD0E4065; Fri, 25 Sep 2015 07:51:25 +0200 (CEST) Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.248.2; Fri, 25 Sep 2015 09:29:34 -0400 Subject: Re: [PATCH 2/2] Add some more casts (1/2) To: Yao Qi References: <1443036644-583-1-git-send-email-simon.marchi@ericsson.com> <86fv228wpz.fsf@gmail.com> CC: From: Simon Marchi Message-ID: <56054C3E.9080301@ericsson.com> Date: Fri, 25 Sep 2015 13:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <86fv228wpz.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00578.txt.bz2 On 15-09-25 09:17 AM, Yao Qi wrote: > Simon Marchi writes: > >> - const struct signal_catchpoint *c = (void *) bl->owner; >> + const struct signal_catchpoint *c = >> + (const struct signal_catchpoint *) bl->owner; > > Nit here: "=" should be put the beginning of next line, like > > const struct signal_catchpoint *c > = (const struct signal_catchpoint *) bl->owner; > > GNU Coding Standards says "When you split an expression into multiple > lines, split it before an operator, not after one." There are multiple > instances of this problem. > > OK with them fixed. I saw that, but didn't know that it applied to the assignment operator as well. IMO, moving the = to the second line does not improve readability and potentially causes even more line wrapping. Anyhow, I'll fix those to conform to GNU Coding Standards. Thanks!