From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100494 invoked by alias); 25 Sep 2015 13:17:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100481 invoked by uid 89); 25 Sep 2015 13:17:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f50.google.com Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 25 Sep 2015 13:17:20 +0000 Received: by pablk4 with SMTP id lk4so9154466pab.3 for ; Fri, 25 Sep 2015 06:17:18 -0700 (PDT) X-Received: by 10.66.163.228 with SMTP id yl4mr7179139pab.112.1443187038532; Fri, 25 Sep 2015 06:17:18 -0700 (PDT) Received: from E107787-LIN (power-aix.osuosl.org. [140.211.15.154]) by smtp.gmail.com with ESMTPSA id gv1sm4011825pbc.38.2015.09.25.06.17.16 (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Fri, 25 Sep 2015 06:17:17 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH 2/2] Add some more casts (1/2) References: <1443036644-583-1-git-send-email-simon.marchi@ericsson.com> Date: Fri, 25 Sep 2015 13:17:00 -0000 In-Reply-To: <1443036644-583-1-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Wed, 23 Sep 2015 15:30:43 -0400") Message-ID: <86fv228wpz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00575.txt.bz2 Simon Marchi writes: > - const struct signal_catchpoint *c =3D (void *) bl->owner; > + const struct signal_catchpoint *c =3D > + (const struct signal_catchpoint *) bl->owner; Nit here: "=3D" should be put the beginning of next line, like const struct signal_catchpoint *c =3D (const struct signal_catchpoint *) bl->owner; GNU Coding Standards says "When you split an expression into multiple lines, split it before an operator, not after one." There are multiple instances of this problem. OK with them fixed. --=20 Yao (=E9=BD=90=E5=B0=A7)