Re: patch to add QNX NTO i386 support

[Mark Kettenis <kettenis@chello.nl>]

"Kris Warkentin" <kewarken@qnx.com> writes:

> Please let me know if the patch and these ChangeLog entries are
> satisfactory.

Thanks for the contribution.  Andrew already posted some comments, but
here are a few more comments that are more specific for those parts of
your patch that are i386-specefic.

The i386-target was "multi-arched" a while ago, which unfortunately
means that your patch will need extensive modification before we can
add it.  Don't worry, I'll help you where needed.

Basically, most of what's in your tm-i386nto.h file will have to go.
Instead you should create a i386nto-tdep.c file where you put and
register an OS/ABI handler for you OS.  Based on the contents of yoyr
tm.h file, you should probably base your OS/ABI handler on
i386-tdep.c:i386_svr4_init_abi().  AFAICT, you'll need
set_gdbarch_decr_pc_after_break() and
set_solib_svr4_fetch_link_map_offsets() there.  Move
i386_qnx_xvr4_link_map_offsets to that file.

You'll also need to find a way to distinguish QNX binaries from other
OS'es.  The hardware breakpoint stuff will have to be moved to the
nm.h.  Most of the other stuff shouldn't be necessary or should be
moved there too.

You should probably use xm-i386.h as your xm.h file.  The other stuff
should either be discarded or moved to your nm.h file too.

I don't think you should try to match x86-*-nto* in configure.host;
the configure.tgt doesn't either.

As Andrew already said, it is probably a good idea to add the QNX i386
target stuff first, such that we can build cross-debuggers for it.
Then we can look more closely at the native stuff.

Mark