From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27339 invoked by alias); 5 Feb 2003 20:48:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27324 invoked from network); 5 Feb 2003 20:48:07 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by 172.16.49.205 with SMTP; 5 Feb 2003 20:48:07 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6/8.12.5) with ESMTP id h15KlW2H000288; Wed, 5 Feb 2003 21:47:32 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6/8.12.6) with ESMTP id h15KlWAr000622; Wed, 5 Feb 2003 21:47:32 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6/8.12.6/Submit) id h15KlW9n000619; Wed, 5 Feb 2003 21:47:32 +0100 (CET) To: "Kris Warkentin" Cc: Subject: Re: patch to add QNX NTO i386 support References: <1c3601c2cbc1$72eac3b0$0202040a@catdog> From: Mark Kettenis Date: Wed, 05 Feb 2003 20:48:00 -0000 In-Reply-To: "Kris Warkentin"'s message of "Mon, 3 Feb 2003 15:18:43 -0500" Message-ID: <86d6m6e9p7.fsf@elgar.kettenis.dyndns.org> X-SW-Source: 2003-02/txt/msg00197.txt.bz2 "Kris Warkentin" writes: > Please let me know if the patch and these ChangeLog entries are > satisfactory. Thanks for the contribution. Andrew already posted some comments, but here are a few more comments that are more specific for those parts of your patch that are i386-specefic. The i386-target was "multi-arched" a while ago, which unfortunately means that your patch will need extensive modification before we can add it. Don't worry, I'll help you where needed. Basically, most of what's in your tm-i386nto.h file will have to go. Instead you should create a i386nto-tdep.c file where you put and register an OS/ABI handler for you OS. Based on the contents of yoyr tm.h file, you should probably base your OS/ABI handler on i386-tdep.c:i386_svr4_init_abi(). AFAICT, you'll need set_gdbarch_decr_pc_after_break() and set_solib_svr4_fetch_link_map_offsets() there. Move i386_qnx_xvr4_link_map_offsets to that file. You'll also need to find a way to distinguish QNX binaries from other OS'es. The hardware breakpoint stuff will have to be moved to the nm.h. Most of the other stuff shouldn't be necessary or should be moved there too. You should probably use xm-i386.h as your xm.h file. The other stuff should either be discarded or moved to your nm.h file too. I don't think you should try to match x86-*-nto* in configure.host; the configure.tgt doesn't either. As Andrew already said, it is probably a good idea to add the QNX i386 target stuff first, such that we can build cross-debuggers for it. Then we can look more closely at the native stuff. Mark