Re: patch to add QNX NTO i386 support

[Andrew Cagney <ac131313@redhat.com>]

Suggest separating the GDB stuff out (native, target, remote) and using 
separate e-mail threads to discuss each.

> gdb/ChangeLog entry:
> 
> 2003-03-02    Kris Warkentin    kewarken@qnx.com
> 
>     * config/i386/i386nto.mt: New file

The MH_CFLAGS and XM_FILE flags should not be needed.  Instead 
gdb/configure should be able to handle this.

>     * config/i386/nm-nto.h: New file

The file nm-nto.h should not be needed.  Instead define it's only macro 
  local to remote-nto.c.  (Disclaimer, you're breaking new ground with 
this one.  Some existing targets  don't have xm-*.h files, but I think 
you're first with the no-*.h file).

>     * config/i386/nto.mh: New file

Yes, you need this, you've a native support.

>     * config/i386/tm-i386nto.h: New file

The file tm-i386nto.h should not be needed.  Instead, gdbarch handles 
architecture specific issues.  The only exception is with shared 
libraries (as there is a bit of this that isn't yet multi-arched).  If 
nto has architecture specific features then create an i386-nto-tdep.c or 
nto-tdep.c file (typically it ends up containing the sigtramp code).

>     * config/i386/xm-nto.h: New file

The file xm-nto.h should not be needed.  gdb/configure should be able to 
handle all host specific problems.

>     * config/tm-qnxnto.h: New file
>     * configure.host: add gdb_host=nto
>     * configure.tgt: add gdb_target=i386nto
>     * nto-procfs.c: New file

Once the target stuff is sorted, please re-submit nto-procfs.c as a 
separate patch.

>     * nto-share/debug.h: New file
>     * nto-share/dsmsgs.h: New file

>     * remote-nto-i386.c: New file
>     * remote-nto.c: New file

Can you expand on how these relate to each other?

>     * ser-ntopty.c: New file

Hmm, is this specific to nto?  Also, glancing through the code, how 
different is this to the existing serial code.  I'm wondering if the 
file exists due to local fixes and not because it is needed.

--


Regarding coding standards.

Look through http://sources.redhat.com/gdb/current/ari/.
Anything listed under `Critical', `Code', or `Fixed' should be 
addressed, also glance through `info'.  I immediatly noticed `PARAMS()' 
(GDB uses ISO C) `//' (C, not C++) and `extern' in C files (always bad).

All files need a proper (C) notice at the top.  The year should include 
`2003' since this is the year that the FSF will first include it.

Run all the new files through ./gdb_indent.sh.

Audit all `#ifdef ...' many of those macro's have been deleted (I 
noticed TARGET_BYTE_ORDER_SELECTABLE'.

Many of the functions have `^qnx_' prefixes.  Should they be given 
`^nto_' prefixes?