From: Andrew Cagney <ac131313@redhat.com>
To: Kris Warkentin <kewarken@qnx.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: patch to add QNX NTO i386 support
Date: Wed, 05 Feb 2003 02:40:00 -0000 [thread overview]
Message-ID: <3E407997.1060700@redhat.com> (raw)
In-Reply-To: <006801c2ccb6$519f8c40$2a00a8c0@dash>
> Suggest separating the GDB stuff out (native, target, remote) and using
>> separate e-mail threads to discuss each.
>
>
> I was going to but it's easier this way.
It isn't for the person doing the review -> the easier the reviewer's
life is, the quicker (well, ok, in theory :-/) the reviewer should be.
I'd strongly focus on getting the cross debugger
(--target=i386-unknown-nto) integrated into GDB, and then worry above
the native.
> The native nto-procfs.c makes use
> of some of the code in remote-qnx.c and remote-qnx-<target>.c (we
still have
> four more targets.) If you really feel it's necessary I could do the
work
> but I had started on it and concluded it would either lead to a lot of
> duplicated code or an explosion of files.
That looks like a design problem. The common code should likely be
moved to something like nto-tdep.c. What exactly is common?
Andrew
next prev parent reply other threads:[~2003-02-05 2:40 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-03 20:19 Kris Warkentin
2003-02-04 7:23 ` Eli Zaretskii
2003-02-04 13:33 ` Kris Warkentin
2003-02-04 13:53 ` Kris Warkentin
2003-02-04 19:59 ` Eli Zaretskii
2003-02-04 20:12 ` Kris Warkentin
2003-02-05 5:50 ` Eli Zaretskii
2003-02-04 22:02 ` Andrew Cagney
2003-02-05 1:29 ` Kris Warkentin
2003-02-05 2:40 ` Andrew Cagney [this message]
2003-02-05 2:59 ` Andrew Cagney
2003-02-05 12:31 ` Kris Warkentin
2003-02-05 2:55 ` Andrew Cagney
2003-02-05 17:15 ` Kris Warkentin
2003-02-05 18:46 ` Andrew Cagney
2003-02-07 1:48 ` Kris Warkentin
2003-02-07 19:22 ` Mark Kettenis
2003-02-07 20:08 ` Kris Warkentin
2003-02-07 21:59 ` Andrew Cagney
2003-02-11 18:11 ` Kris Warkentin
2003-02-11 18:41 ` patch to add HAVE_CONTINUABLE_BREAKPOINT to target_ops Kris Warkentin
2003-02-12 22:18 ` patch to add QNX NTO i386 support Kris Warkentin
2003-02-12 22:44 ` Daniel Jacobowitz
2003-02-13 0:52 ` Kris Warkentin
2003-02-13 22:21 ` Mark Kettenis
2003-02-13 22:29 ` Kris Warkentin
2003-02-13 22:53 ` Mark Kettenis
2003-02-13 23:55 ` Kris Warkentin
2003-02-14 0:01 ` Kris Warkentin
2003-02-13 21:56 ` Kris Warkentin
2003-02-13 22:08 ` Daniel Jacobowitz
2003-02-13 22:25 ` Kris Warkentin
2003-02-13 22:29 ` Daniel Jacobowitz
2003-02-13 23:48 ` Kris Warkentin
2003-02-14 0:03 ` Daniel Jacobowitz
2003-02-14 0:09 ` Kris Warkentin
2003-02-14 0:13 ` Daniel Jacobowitz
2003-02-14 0:35 ` Kris Warkentin
2003-02-17 14:58 ` Andrew Cagney
2003-02-17 15:44 ` Daniel Jacobowitz
2003-02-17 16:45 ` Andrew Cagney
2003-02-17 18:54 ` Kris Warkentin
2003-02-18 21:26 ` Andrew Cagney
2003-02-18 22:30 ` Kris Warkentin
2003-02-20 0:42 ` Andrew Cagney
2003-02-27 19:02 ` Kris Warkentin
2003-02-27 19:56 ` Andrew Cagney
2003-02-27 20:02 ` Daniel Jacobowitz
2003-02-27 20:10 ` Andrew Cagney
2003-02-27 20:11 ` Kris Warkentin
2003-02-27 20:23 ` Andrew Cagney
2003-02-27 20:28 ` Kris Warkentin
2003-02-05 20:48 ` Mark Kettenis
2003-02-05 21:23 ` Kris Warkentin
2003-02-05 21:43 ` Kris Warkentin
2003-02-05 22:24 ` Mark Kettenis
2003-02-06 15:13 ` Kris Warkentin
2003-02-06 18:19 ` Andrew Cagney
2003-02-05 22:48 ` Mark Kettenis
2003-02-06 15:08 ` Kris Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E407997.1060700@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kewarken@qnx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox