From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>, Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH 1/3] gdb lwp_info: Add destructor, initialize fields, use new/delete
Date: Tue, 25 Jul 2017 09:39:00 -0000 [thread overview]
Message-ID: <8660egrh2m.fsf@gmail.com> (raw)
In-Reply-To: <1500892797-7523-2-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Mon, 24 Jul 2017 12:39:55 +0200")
Simon Marchi <simon.marchi@ericsson.com> writes:
> gdb/ChangeLog:
>
> * linux-nat.h (struct lwp_info): Add constructor, initialize
> fields with default values.
> <must_set_ptrace_flags, signalled, stopped, resumed, step,
> stopped_data_address, ignore_sigint>: Change type to bool.
> * linux-nat.c (linux_child_follow_fork): Adapt to type change to
> bool.
> (lwp_free): Use delete on lp.
> (add_initial_lwp): Create lwp_info by calling lwp_info constructor.
> (delete_lwp): Likewise.
> (find_lwp_pid): Likewise.
> (linux_nat_switch_fork): Adapt to type change to bool.
> (linux_nat_post_attach_wait): Change type of SIGNALLED parameter
> to bool *.
> (attach_proc_task_lwp_callback): Adapt to type change to bool.
> (linux_nat_attach): Adapt to type change to bool.
> (detach_one_lwp): Likewise.
> (linux_resume_one_lwp_throw): Likewise.
> (resume_clear_callback): Likewise.
> (resume_set_callback): Likewise.
> (linux_handle_syscall_trap): Likewise.
> (linux_handle_extended_wait): Likewise.
> (wait_lwp): Likewise.
> (stop_callback): Likewise.
> (set_ignore_sigint): Likewise.
> (maybe_clear_ignore_sigint): Likewise.
> (check_stopped_by_watchpoint): Likewise.
> (stop_wait_callback): Likewise.
> (linux_nat_filter_event): Likewise.
> (linux_nat_wait_1): Likewise.
Patch is good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-07-25 9:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 10:40 [PATCH 0/3] Create arch_lwp_info class hierarchy Simon Marchi
2017-07-24 10:40 ` [PATCH 3/3] " Simon Marchi
2017-08-09 20:47 ` Simon Marchi
2017-07-24 10:40 ` [PATCH 2/3] gdbserver lwp_info: Initialize fields, use new/delete Simon Marchi
2017-07-25 9:58 ` Yao Qi
2017-07-25 10:19 ` Simon Marchi
2017-07-25 15:25 ` Yao Qi
2017-07-24 10:40 ` [PATCH 1/3] gdb lwp_info: Add destructor, initialize " Simon Marchi
2017-07-24 10:43 ` Simon Marchi
2017-07-25 9:39 ` Yao Qi [this message]
2017-08-11 20:13 ` [PATCH 0/3] Create arch_lwp_info class hierarchy Pedro Alves
2017-08-12 11:31 ` Simon Marchi
2017-08-14 11:53 ` Pedro Alves
2017-08-16 18:44 ` Simon Marchi
2017-08-18 11:23 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8660egrh2m.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox