From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98319 invoked by alias); 25 Jul 2017 09:39:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97876 invoked by uid 89); 25 Jul 2017 09:39:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-io0-f193.google.com Received: from mail-io0-f193.google.com (HELO mail-io0-f193.google.com) (209.85.223.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Jul 2017 09:39:37 +0000 Received: by mail-io0-f193.google.com with SMTP id j32so3331976iod.3 for ; Tue, 25 Jul 2017 02:39:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=KPgao66fZg2eh3TI7RQkE1qhfih8DaQDsvg/fEoo0J8=; b=iZTSx350qV6I1/OSIY08ff6QutCLqM3eA8plrjEcL3Fw+KroDjb2ATNwkgnzbv0yqH tTotlUutkWP3GyiJs2OFmwq9YWNK4JYofd9zdbTbgbb/uTjohae4lFm5hHkvnY0DPz+B EXWhQNj1fkZ74KBMlYb/6L8tpR8esSnm9TcDilD6ygDasdt8LEAdSY+DIowHfFL0XUZc rM/AQxJiOnWga6khkz1oXunxvdgRfOMmiY2UkITwrHQLUq7DzN2bf69CbXaBHsS6swF3 +VdnpT6e+SV6r0if/uZHrkiyhKInKIslHAn/Kbz1fcBVy0kIUOitSbOqGrXHWF+/S/jN pQgA== X-Gm-Message-State: AIVw113XOtAGVr0SYVP46Y/t4zExCY54fTFGmImAoUAqz0muE4K1bYNF FPYd6GM+JwgYmg== X-Received: by 10.107.8.208 with SMTP id h77mr14852775ioi.69.1500975575733; Tue, 25 Jul 2017 02:39:35 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id n10sm2235438itb.1.2017.07.25.02.39.34 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 25 Jul 2017 02:39:35 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: , Simon Marchi Subject: Re: [PATCH 1/3] gdb lwp_info: Add destructor, initialize fields, use new/delete References: <1500892797-7523-1-git-send-email-simon.marchi@ericsson.com> <1500892797-7523-2-git-send-email-simon.marchi@ericsson.com> Date: Tue, 25 Jul 2017 09:39:00 -0000 In-Reply-To: <1500892797-7523-2-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Mon, 24 Jul 2017 12:39:55 +0200") Message-ID: <8660egrh2m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00360.txt.bz2 Simon Marchi writes: > gdb/ChangeLog: > > * linux-nat.h (struct lwp_info): Add constructor, initialize > fields with default values. > stopped_data_address, ignore_sigint>: Change type to bool. > * linux-nat.c (linux_child_follow_fork): Adapt to type change to > bool. > (lwp_free): Use delete on lp. > (add_initial_lwp): Create lwp_info by calling lwp_info constructor. > (delete_lwp): Likewise. > (find_lwp_pid): Likewise. > (linux_nat_switch_fork): Adapt to type change to bool. > (linux_nat_post_attach_wait): Change type of SIGNALLED parameter > to bool *. > (attach_proc_task_lwp_callback): Adapt to type change to bool. > (linux_nat_attach): Adapt to type change to bool. > (detach_one_lwp): Likewise. > (linux_resume_one_lwp_throw): Likewise. > (resume_clear_callback): Likewise. > (resume_set_callback): Likewise. > (linux_handle_syscall_trap): Likewise. > (linux_handle_extended_wait): Likewise. > (wait_lwp): Likewise. > (stop_callback): Likewise. > (set_ignore_sigint): Likewise. > (maybe_clear_ignore_sigint): Likewise. > (check_stopped_by_watchpoint): Likewise. > (stop_wait_callback): Likewise. > (linux_nat_filter_event): Likewise. > (linux_nat_wait_1): Likewise. Patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)