Re: [PATCH 0/3] Create arch_lwp_info class hierarchy

[Pedro Alves <palves@redhat.com>]

On 08/16/2017 07:44 PM, Simon Marchi wrote:
> On 2017-08-14 13:53, Pedro Alves wrote:
>> On 08/12/2017 12:29 PM, Simon Marchi wrote:
>>
>>> But then I realized that I forgot to include the header for s390, and
>>> the compiler (when building for a s390 host) didn't warn me.  This is
>>> dangerous and fragile since we end up with two definitions of
>>> arch_lwp_info (the s390 one and that fallback one), and nothing to warn
>>> about it.
>>
>> Not sure whether that's really such a bad problem.  It seems like the
>> sort of thing that'd crash quite visibly/quickly if you actually try to
>> run the resulting binary.  It's not like we're adding ports
>> every day.  :-)
> 
> How would it crash visibly?  I thought it would most likely crash or
> corrupt memory seemingly randomly.  

Yeah, I'm just assuming that that randomness would be
noticeable quickly, say, in that it likely wouldn't survive
a test run at least.

> That's irrelevant because of you
> suggestion below, but I'm asking just for the sake of the discussion.

Thanks,
Pedro Alves