From: Yao Qi <qiyaoltc@gmail.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] gdbserver lwp_info: Initialize fields, use new/delete
Date: Tue, 25 Jul 2017 09:58:00 -0000 [thread overview]
Message-ID: <861sp4rg6i.fsf@gmail.com> (raw)
In-Reply-To: <1500892797-7523-3-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Mon, 24 Jul 2017 12:39:56 +0200")
Simon Marchi <simon.marchi@ericsson.com> writes:
> @@ -3480,7 +3476,7 @@ linux_wait_1 (ptid_t ptid,
> event_child->collecting_fast_tracepoint
> = linux_fast_tracepoint_collecting (event_child, NULL);
>
> - if (event_child->collecting_fast_tracepoint != 1)
> + if (!event_child->collecting_fast_tracepoint)
> {
> /* No longer need this breakpoint. */
> if (event_child->exit_jump_pad_bkpt != NULL)
linux_fast_tracepoint_collecting doesn't return boolean, it returns 0, 1
and 2. See comments in tracepoint.c:fast_tracepoint_collecting.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-07-25 9:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 10:40 [PATCH 0/3] Create arch_lwp_info class hierarchy Simon Marchi
2017-07-24 10:40 ` [PATCH 3/3] " Simon Marchi
2017-08-09 20:47 ` Simon Marchi
2017-07-24 10:40 ` [PATCH 1/3] gdb lwp_info: Add destructor, initialize fields, use new/delete Simon Marchi
2017-07-24 10:43 ` Simon Marchi
2017-07-25 9:39 ` Yao Qi
2017-07-24 10:40 ` [PATCH 2/3] gdbserver lwp_info: Initialize " Simon Marchi
2017-07-25 9:58 ` Yao Qi [this message]
2017-07-25 10:19 ` Simon Marchi
2017-07-25 15:25 ` Yao Qi
2017-08-11 20:13 ` [PATCH 0/3] Create arch_lwp_info class hierarchy Pedro Alves
2017-08-12 11:31 ` Simon Marchi
2017-08-14 11:53 ` Pedro Alves
2017-08-16 18:44 ` Simon Marchi
2017-08-18 11:23 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861sp4rg6i.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox