From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105923 invoked by alias); 25 Jul 2017 09:58:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104660 invoked by uid 89); 25 Jul 2017 09:58:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-io0-f170.google.com Received: from mail-io0-f170.google.com (HELO mail-io0-f170.google.com) (209.85.223.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Jul 2017 09:58:50 +0000 Received: by mail-io0-f170.google.com with SMTP id l7so53857393iof.1 for ; Tue, 25 Jul 2017 02:58:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=MaoCTPNJIbKHyK0fJ56wI46WWVjw03BXDavSOfmSw3Q=; b=fNWPZelbz9k653yzq3rxJFwi2JIq12fBlv9Qqa3eUK47nxBs+XYsXfyGTQkNUibuiV jNmY0vHG0AJ8fRj5MbYUbIV3FO6/CIOQfNCmHIUvOIbJV1zfHk/JVZ8ovzrsvkHiD6d+ EMnPlMwslNySrrGarCK/0wQr5vZ6SqBgZ+6fqsu6EqzU4k3hreNqTCPxjfTkKvIK0u2I E0y3Dkq1cNGkLmfCrEgMLpsz8/V3yZ8sWEi/xdvK3SqThhgiHvu7w01wpVi0wkJkzDQc 4Zw2rTgO79nS9F/c0OAcznlvIEvJNEdFsfExOr/rVtyemUGiGuIxnQ4lvTJqq39yvMTd u6Mg== X-Gm-Message-State: AIVw111d28r0xsXX1P1id2GRF4RL9MwNr/N6rXYi2DozJ4fdHTEOk5RB eJqYY2f68tIEQMSL X-Received: by 10.107.205.72 with SMTP id d69mr4067493iog.224.1500976728360; Tue, 25 Jul 2017 02:58:48 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id q81sm4887697itb.28.2017.07.25.02.58.47 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 25 Jul 2017 02:58:47 -0700 (PDT) From: Yao Qi To: Simon Marchi Cc: Subject: Re: [PATCH 2/3] gdbserver lwp_info: Initialize fields, use new/delete References: <1500892797-7523-1-git-send-email-simon.marchi@ericsson.com> <1500892797-7523-3-git-send-email-simon.marchi@ericsson.com> Date: Tue, 25 Jul 2017 09:58:00 -0000 In-Reply-To: <1500892797-7523-3-git-send-email-simon.marchi@ericsson.com> (Simon Marchi's message of "Mon, 24 Jul 2017 12:39:56 +0200") Message-ID: <861sp4rg6i.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00361.txt.bz2 Simon Marchi writes: > @@ -3480,7 +3476,7 @@ linux_wait_1 (ptid_t ptid, > event_child->collecting_fast_tracepoint > =3D linux_fast_tracepoint_collecting (event_child, NULL); >=20=20 > - if (event_child->collecting_fast_tracepoint !=3D 1) > + if (!event_child->collecting_fast_tracepoint) > { > /* No longer need this breakpoint. */ > if (event_child->exit_jump_pad_bkpt !=3D NULL) linux_fast_tracepoint_collecting doesn't return boolean, it returns 0, 1 and 2. See comments in tracepoint.c:fast_tracepoint_collecting. --=20 Yao (=E9=BD=90=E5=B0=A7)