From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46180 invoked by alias); 18 Aug 2017 11:23:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 45843 invoked by uid 89); 18 Aug 2017 11:23:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Aug 2017 11:23:50 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id ED7A0356EA; Fri, 18 Aug 2017 11:23:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com ED7A0356EA Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2048A70637; Fri, 18 Aug 2017 11:23:47 +0000 (UTC) Subject: Re: [PATCH 0/3] Create arch_lwp_info class hierarchy To: Simon Marchi References: <1500892797-7523-1-git-send-email-simon.marchi@ericsson.com> <22f9058d-52de-293a-eef8-6af1572955d0@redhat.com> Cc: Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <453b1d5a-8873-dc47-4a91-abb4fabe6b72@redhat.com> Date: Fri, 18 Aug 2017 11:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00361.txt.bz2 On 08/16/2017 07:44 PM, Simon Marchi wrote: > On 2017-08-14 13:53, Pedro Alves wrote: >> On 08/12/2017 12:29 PM, Simon Marchi wrote: >> >>> But then I realized that I forgot to include the header for s390, and >>> the compiler (when building for a s390 host) didn't warn me. This is >>> dangerous and fragile since we end up with two definitions of >>> arch_lwp_info (the s390 one and that fallback one), and nothing to warn >>> about it. >> >> Not sure whether that's really such a bad problem. It seems like the >> sort of thing that'd crash quite visibly/quickly if you actually try to >> run the resulting binary. It's not like we're adding ports >> every day. :-) > > How would it crash visibly? I thought it would most likely crash or > corrupt memory seemingly randomly. Yeah, I'm just assuming that that randomness would be noticeable quickly, say, in that it likely wouldn't survive a test run at least. > That's irrelevant because of you > suggestion below, but I'm asking just for the sake of the discussion. Thanks, Pedro Alves