Re: [PATCH 1/2] gdb/alpha: Add target description support

[Eli Zaretskii <eliz@gnu.org>]

> From: Yodel Eldar <yodel.eldar@gmail.com>
> Cc: Yodel Eldar <yodel.eldar@gmail.com>
> Date: Mon, 26 May 2025 10:12:18 -0500
> 
> This commit adds target description support for Alpha.
> 
> The target description obviates the alpha_register_type and
> alpha_register_name functions in alpha-tdep.c. Removal of
> alpha_register_reggroup_p was considered but ultimately abandoned,
> because the "info regs" command would no longer omit the zero, fpcr, and
> unique registers from its output (they are neither vector nor float
> types).
> 
> Register types in the target description annex match the types that the
> alpha_register_type function returned.
> 
> The locally defined register_names array was moved out of
> alpha_register_name and renamed to alpha_register_names as a static
> global; calls to alpha_register_name have been replaced with direct
> access of the array.
> 
> The patch follows the code pattern outlined in the following GDB
> Internals Wiki entry:
> 
> https://sourceware.org/gdb/wiki/Internals%20Adding-Target-Described-Register-Support
> ---
>  gdb/NEWS                    |  2 +
>  gdb/alpha-tdep.c            | 87 ++++++++++++++++++++----------------
>  gdb/doc/gdb.texinfo         | 42 ++++++++++++++++++
>  gdb/features/Makefile       |  1 +
>  gdb/features/alpha-core.xml | 88 +++++++++++++++++++++++++++++++++++++
>  gdb/features/alpha.c        | 84 +++++++++++++++++++++++++++++++++++
>  gdb/features/alpha.xml      | 11 +++++
>  7 files changed, 276 insertions(+), 39 deletions(-)
>  create mode 100644 gdb/features/alpha-core.xml
>  create mode 100644 gdb/features/alpha.c
>  create mode 100644 gdb/features/alpha.xml

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 2e48a00df5a..099c137a16f 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -195,6 +195,8 @@ qXfer:threads:read
>    subsystem to be disabled at configure time, in the form of
>    --disable-gdb-compile.
>  
> +* The Alpha target now supports target descriptions.
> +
>  *** Changes in GDB 16

This part is okay.

> +The @samp{org.gnu.gdb.alpha.core} feature is required for Alpha targets. It
                                                                          ^^
Two spaces between sentences, please.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>