From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id D8tsAoKUNGivXjUAWB0awg (envelope-from ) for ; Mon, 26 May 2025 12:19:14 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=S86+oGjK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EE6FE1E11C; Mon, 26 May 2025 12:19:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 538CA1E102 for ; Mon, 26 May 2025 12:19:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9F3DE3857830 for ; Mon, 26 May 2025 16:19:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F3DE3857830 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gnu.org header.i=@gnu.org header.a=rsa-sha256 header.s=fencepost-gnu-org header.b=S86+oGjK Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 70168385AC2E for ; Mon, 26 May 2025 16:13:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70168385AC2E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 70168385AC2E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748276010; cv=none; b=A+eWVwkidZq5lrWHZBnLtHdJoU//r5yCPCRlMPLosEy9YWxhf9d7kd479E5/UrkviT7h5XIQ+L27OjrV5qjQnM35V6xnDs6TkZcNK8aYV/EfnP+GglsssjGajBBTtZXAyM0Q8YinVFjlU7aX9tZLMzEcIZB2ApoRUqQNDvAMRaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748276010; c=relaxed/simple; bh=kHBBl895zJgLMozgBX/b6pZRSM9s8Gita9La5z+oLdQ=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=rG2CrAZlJ3n0SXpHY7bBuzCNsX/dvkQIWMUYWfSGItddqD9plOngkH38GzR6X0TVsNSuwmk/vOTQxw5FTVxuv040pzcLchHdEgXCqsXp3LXNmUO4+L+qjURVccgM8AySz3eXRoQx5JFqZlFFJEfXjzNqVuVwm2lCnhOpgxtGC6A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uJaS9-0006Ve-Jr; Mon, 26 May 2025 12:13:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Cjzz4GxgqbG90DCfTyLNXrKsEERK5mF5MpQFPTTBEzc=; b=S86+oGjKqNyZ AoyIIZgY4HEEGkLkVeZDhpF6uJeyXWqWAGYP4pGUDKjeJEzT5ThAoOPXUAHYB8ILXKEsSprXD7dLV HvlAMam3AYALnJJeuzeTnpIKhrVcpqXI+oFLaJeGTFEslYlgXxy6kjyP+yNLtvV013YduH3iGCo3V qRwpEwbV00dAG5RjYrFL3ZzkgMtoAPPMhahF026QegkfTcZ6sCR3L1U289vxX5BsZ+zj+KRRGHGQz X0RLVz5zhyDfg5Z8cjIOtgKzUwl0IM11xZOHV+cyhrIE1NxaL5kzWPRELqrGfjnBWQbpjJut67OcO WT/n53hezvNZKuyj8tuMMw==; Date: Mon, 26 May 2025 19:13:17 +0300 Message-Id: <8634crz6xu.fsf@gnu.org> From: Eli Zaretskii To: Yodel Eldar Cc: gdb-patches@sourceware.org In-Reply-To: <20250526151219.399450-2-yodel.eldar@gmail.com> (message from Yodel Eldar on Mon, 26 May 2025 10:12:18 -0500) Subject: Re: [PATCH 1/2] gdb/alpha: Add target description support References: <20250526151219.399450-1-yodel.eldar@gmail.com> <20250526151219.399450-2-yodel.eldar@gmail.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > From: Yodel Eldar > Cc: Yodel Eldar > Date: Mon, 26 May 2025 10:12:18 -0500 > > This commit adds target description support for Alpha. > > The target description obviates the alpha_register_type and > alpha_register_name functions in alpha-tdep.c. Removal of > alpha_register_reggroup_p was considered but ultimately abandoned, > because the "info regs" command would no longer omit the zero, fpcr, and > unique registers from its output (they are neither vector nor float > types). > > Register types in the target description annex match the types that the > alpha_register_type function returned. > > The locally defined register_names array was moved out of > alpha_register_name and renamed to alpha_register_names as a static > global; calls to alpha_register_name have been replaced with direct > access of the array. > > The patch follows the code pattern outlined in the following GDB > Internals Wiki entry: > > https://sourceware.org/gdb/wiki/Internals%20Adding-Target-Described-Register-Support > --- > gdb/NEWS | 2 + > gdb/alpha-tdep.c | 87 ++++++++++++++++++++---------------- > gdb/doc/gdb.texinfo | 42 ++++++++++++++++++ > gdb/features/Makefile | 1 + > gdb/features/alpha-core.xml | 88 +++++++++++++++++++++++++++++++++++++ > gdb/features/alpha.c | 84 +++++++++++++++++++++++++++++++++++ > gdb/features/alpha.xml | 11 +++++ > 7 files changed, 276 insertions(+), 39 deletions(-) > create mode 100644 gdb/features/alpha-core.xml > create mode 100644 gdb/features/alpha.c > create mode 100644 gdb/features/alpha.xml Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index 2e48a00df5a..099c137a16f 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -195,6 +195,8 @@ qXfer:threads:read > subsystem to be disabled at configure time, in the form of > --disable-gdb-compile. > > +* The Alpha target now supports target descriptions. > + > *** Changes in GDB 16 This part is okay. > +The @samp{org.gnu.gdb.alpha.core} feature is required for Alpha targets. It ^^ Two spaces between sentences, please. Reviewed-By: Eli Zaretskii