Re: [PATCH 1/2] gdb/alpha: Add target description support

[Simon Marchi <simark@simark.ca>]

On 2025-07-02 15:21, Maciej W. Rozycki wrote:
> On Wed, 2 Jul 2025, Simon Marchi wrote:
> 
>>>> >From my non-Alpha-expert point of view, the series LGTM, so I'm tempted
>>>> to approve it.  Maciej, did you have some comments on the code?  Does it
>>>> look good to you?
>>>
>>>  I've skimmed over now and found one minor formatting nit only, which I do 
>>> hope you can address as you push this change.  Otherwise if there turns 
>>> out indeed anything wrong with the code later on, it can be dealt with as 
>>> required.  I'm not prepared right now for any further verification of this 
>>> target.
>>
>> I didn't fix any formatting problem other than the one pointed out by
>> Eli.  What did you find?  Or else, feel free to fix it by yourself with
>> an obvious patch.
> 
>  Just a place asking for a new line for legibility reasons.  If you've 
> already pushed the change, then I can apply a follow-up update myself.
> 
>   Maciej

Ah ok, I missed that message.  I just pushed this:


From 01d8dc11f18d774bc92b0b752e36510f86c6725c Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@polymtl.ca>
Date: Thu, 3 Jul 2025 12:00:49 -0400
Subject: [PATCH] gdb/alpha-tdep: add empty line

This was suggested in review, to separate the comment from the following
code.

Change-Id: I077ad4545ee5ef1d362dcfacf585400e26dfdb29
---
 gdb/alpha-tdep.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/alpha-tdep.c b/gdb/alpha-tdep.c
index 5e8a7a02c2fa..d655c13b8293 100644
--- a/gdb/alpha-tdep.c
+++ b/gdb/alpha-tdep.c
@@ -1829,6 +1829,7 @@ INIT_GDB_FILE (alpha_tdep)
   gdbarch_register (bfd_arch_alpha, alpha_gdbarch_init, NULL);
 
   initialize_tdesc_alpha ();
+
   /* Let the user set the fence post for heuristic_proc_start.  */
 
   /* We really would like to have both "0" and "unlimited" work, but

base-commit: 239f72374aab88a5b16855c01e75ed2c5b10960f
-- 
2.50.0