From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Me9xHZ2pZmiPUSoAWB0awg (envelope-from ) for ; Thu, 03 Jul 2025 12:02:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1751558557; bh=a1Ya7auUI+033tgJD/4S3kcoP780pleR2LABvlDyAcc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fRb0Cth6CHnRkSDDwjhKYaUB3/MQIzdWIM+neRzfnfYlGvO9he6p2JupLBXIHCixv 52ZeZfNLhnzl75R7wtS8IkXmhjQcIuSV2LTUnjqW6ueLhkQtEsRrxzWZWx7y4urAnJ zX8QECHbnuqom/ykpDZw8ZC+HjKx+0hTEkyKq8Vc= Received: by simark.ca (Postfix, from userid 112) id 61E6B1E11E; Thu, 3 Jul 2025 12:02:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=PfjUlkLw; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=hVWUlzvK; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C70811E102 for ; Thu, 3 Jul 2025 12:02:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 596943852103 for ; Thu, 3 Jul 2025 16:02:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 596943852103 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=PfjUlkLw; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=hVWUlzvK Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 76E49385357E for ; Thu, 3 Jul 2025 16:02:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 76E49385357E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 76E49385357E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751558527; cv=none; b=lNOeyOTr0nVWx9/ByAiz+Ve8X9Mfbjb6FfpGVMkk/4ny+Ot/+fDwImesLLMtfoCn+rEbvyMgOTAl9lo7heTTB2npDrh7qtaDxZR2HrDM2C4lVft3HJ1l5M+UTuvM9CCHrGJ9RlJ9hd5W9FDPiBXv8Nh/aUcKnuMn+V5kZq/Tf20= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751558527; c=relaxed/simple; bh=a1Ya7auUI+033tgJD/4S3kcoP780pleR2LABvlDyAcc=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=aEaFXcp4tOvvU9fsfSbZW13cPNI6lzWWEL1RtpfQECZHREkMxRxck0abzwEgerpFHspf3aN57WlVQFwbJI6byLoGM+cm+7yHNxSjHoVF6qGSr60PT82seFe1uv5SdjYUeJRhAzLfsxJ0hPQIPe5VjrKmy97gHOVoty4qVpOgnlI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76E49385357E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1751558527; bh=a1Ya7auUI+033tgJD/4S3kcoP780pleR2LABvlDyAcc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PfjUlkLwLqqrvz7Q+hrISioGdjvSa7GbObA6MkNnRksbjCOKuM+LZLpCdVewHcHaO vpeQ9RMbF0tE60Juw4jv0m06elGeImLfaXjkUPan6X6kCSiD6X1n7Y6cusvd1DVcai 6Mri1PilYmzMi7mLLl0iWjKmAaMDpCpIdJjAFgWU= Received: by simark.ca (Postfix, from userid 112) id 250401E126; Thu, 3 Jul 2025 12:02:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1751558525; bh=a1Ya7auUI+033tgJD/4S3kcoP780pleR2LABvlDyAcc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hVWUlzvK25iIqSvPRGctZb6DdS2CqIEpc3AX1zbS0COvcptsgCPbU+PtKSL79MRwI CkClnZf3IJN2Mj+SuYS/aIKXRxKJ72YvCpxi0rrCx0qWi6iJ8zniTn3nK0f3sgrp9g HZQQy+EMOV0F7Uott4C+0hcnxg1ObW3XldHJ3u80= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id AF2271E102; Thu, 3 Jul 2025 12:02:05 -0400 (EDT) Message-ID: <5c5ae748-a3e3-46c4-9f41-e2843dbcd59f@simark.ca> Date: Thu, 3 Jul 2025 12:02:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb/alpha: Add target description support To: "Maciej W. Rozycki" Cc: Yodel Eldar , gdb-patches@sourceware.org References: <20250526151219.399450-1-yodel.eldar@gmail.com> <20250526151219.399450-2-yodel.eldar@gmail.com> <55cdf445-fee8-4e70-99c0-6d42eb68cd7d@simark.ca> <9feb7348-1dde-40cc-b21d-97671b8b3e39@gmail.com> <3ef4c598-28d8-4c66-844d-58e5629415ab@gmail.com> <40cede5f-1b8c-4eb9-b702-3805499efbf5@gmail.com> <869aca3b-78ab-4ec6-af23-56394c040d75@simark.ca> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-07-02 15:21, Maciej W. Rozycki wrote: > On Wed, 2 Jul 2025, Simon Marchi wrote: > >>>> >From my non-Alpha-expert point of view, the series LGTM, so I'm tempted >>>> to approve it. Maciej, did you have some comments on the code? Does it >>>> look good to you? >>> >>> I've skimmed over now and found one minor formatting nit only, which I do >>> hope you can address as you push this change. Otherwise if there turns >>> out indeed anything wrong with the code later on, it can be dealt with as >>> required. I'm not prepared right now for any further verification of this >>> target. >> >> I didn't fix any formatting problem other than the one pointed out by >> Eli. What did you find? Or else, feel free to fix it by yourself with >> an obvious patch. > > Just a place asking for a new line for legibility reasons. If you've > already pushed the change, then I can apply a follow-up update myself. > > Maciej Ah ok, I missed that message. I just pushed this: >From 01d8dc11f18d774bc92b0b752e36510f86c6725c Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 3 Jul 2025 12:00:49 -0400 Subject: [PATCH] gdb/alpha-tdep: add empty line This was suggested in review, to separate the comment from the following code. Change-Id: I077ad4545ee5ef1d362dcfacf585400e26dfdb29 --- gdb/alpha-tdep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/alpha-tdep.c b/gdb/alpha-tdep.c index 5e8a7a02c2fa..d655c13b8293 100644 --- a/gdb/alpha-tdep.c +++ b/gdb/alpha-tdep.c @@ -1829,6 +1829,7 @@ INIT_GDB_FILE (alpha_tdep) gdbarch_register (bfd_arch_alpha, alpha_gdbarch_init, NULL); initialize_tdesc_alpha (); + /* Let the user set the fence post for heuristic_proc_start. */ /* We really would like to have both "0" and "unlimited" work, but base-commit: 239f72374aab88a5b16855c01e75ed2c5b10960f -- 2.50.0