From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Simon Marchi <simark@simark.ca>
Cc: Yodel Eldar <yodel.eldar@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb/alpha: Add target description support
Date: Wed, 2 Jul 2025 19:53:55 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2507021948420.56608@angie.orcam.me.uk> (raw)
In-Reply-To: <869aca3b-78ab-4ec6-af23-56394c040d75@simark.ca>
On Thu, 12 Jun 2025, Simon Marchi wrote:
> >From my non-Alpha-expert point of view, the series LGTM, so I'm tempted
> to approve it. Maciej, did you have some comments on the code? Does it
> look good to you?
I've skimmed over now and found one minor formatting nit only, which I do
hope you can address as you push this change. Otherwise if there turns
out indeed anything wrong with the code later on, it can be dealt with as
required. I'm not prepared right now for any further verification of this
target.
Maciej
next prev parent reply other threads:[~2025-07-02 18:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 15:12 [PATCH 0/2] gdb/alpha: Add target description support and fpcr flags Yodel Eldar
2025-05-26 15:12 ` [PATCH 1/2] gdb/alpha: Add target description support Yodel Eldar
2025-05-26 16:13 ` Eli Zaretskii
2025-05-26 17:14 ` Yodel
2025-06-03 18:49 ` Simon Marchi
2025-06-04 13:44 ` Yodel Eldar
2025-06-04 14:49 ` Maciej W. Rozycki
2025-06-04 17:29 ` Yodel Eldar
2025-06-12 19:29 ` Yodel Eldar
2025-06-12 20:30 ` Simon Marchi
2025-06-12 20:33 ` Simon Marchi
2025-06-12 22:07 ` Yodel Eldar
2025-06-13 14:34 ` Simon Marchi
2025-06-30 0:08 ` Yodel Eldar
2025-07-02 17:14 ` Simon Marchi
2025-07-02 18:51 ` Yodel Eldar
2025-07-02 18:53 ` Maciej W. Rozycki [this message]
2025-07-02 19:02 ` Simon Marchi
2025-07-02 19:21 ` Maciej W. Rozycki
2025-07-02 20:52 ` Yodel Eldar
2025-07-02 21:12 ` Maciej W. Rozycki
2025-07-03 16:49 ` Yodel Eldar
2025-07-03 16:02 ` Simon Marchi
2025-07-02 18:48 ` Maciej W. Rozycki
2025-05-26 15:12 ` [PATCH 2/2] gdb/alpha: Redefine fpcr with fpcr_flags type Yodel Eldar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2507021948420.56608@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=yodel.eldar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox