From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix "list" when control characters are seen
Date: Tue, 18 Jun 2019 15:33:00 -0000 [thread overview]
Message-ID: <86175428-7135-14e2-600d-7952a0064750@redhat.com> (raw)
In-Reply-To: <87lfxylxnw.fsf@tromey.com>
On 6/18/19 4:29 PM, Tom Tromey wrote:
>>> static void foo (int x)
>>> /* !
>>> - !
>>> +
>
> Pedro> This seems pretty obscure without the context of the patch around.
>
> Pedro> Should we add a comment here?
>
> Good idea, how's this?
Looks great, thanks.
Pedro Alves
prev parent reply other threads:[~2019-06-18 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 18:54 Tom Tromey
2019-04-09 19:24 ` Andreas Schwab
2019-04-10 16:53 ` Tom Tromey
2019-04-19 19:03 ` Tom Tromey
2019-06-18 13:24 ` Pedro Alves
2019-06-18 15:29 ` Tom Tromey
2019-06-18 15:33 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86175428-7135-14e2-600d-7952a0064750@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox