From: Andreas Schwab <schwab@linux-m68k.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix "list" when control characters are seen
Date: Tue, 09 Apr 2019 19:24:00 -0000 [thread overview]
Message-ID: <87wok36kyb.fsf@igel.home> (raw)
In-Reply-To: <20190409185432.16985-1-tromey@adacore.com> (Tom Tromey's message of "Tue, 9 Apr 2019 12:54:32 -0600")
On Apr 09 2019, Tom Tromey <tromey@adacore.com> wrote:
> diff --git a/gdb/source.c b/gdb/source.c
> index f99215f9810..b61880ab503 100644
> --- a/gdb/source.c
> +++ b/gdb/source.c
> @@ -1368,7 +1368,7 @@ print_source_lines_base (struct symtab *s, int line, int stopline,
> char c = *iter;
> if (c == '\033' && skip_ansi_escape (iter, &skip_bytes))
> iter += skip_bytes;
> - else if (c < 040 && c != '\t')
> + else if (c >= 0 && c < 040 && c != '\t')
Does this give a warning when char is unsigned?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2019-04-09 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 18:54 Tom Tromey
2019-04-09 19:24 ` Andreas Schwab [this message]
2019-04-10 16:53 ` Tom Tromey
2019-04-19 19:03 ` Tom Tromey
2019-06-18 13:24 ` Pedro Alves
2019-06-18 15:29 ` Tom Tromey
2019-06-18 15:33 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wok36kyb.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox